[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-28 Thread Rob Clark
On Mon, Jan 28, 2013 at 3:56 AM, Mohammed, Afzal wrote: > Hi Rob, > > On Fri, Jan 25, 2013 at 20:22:55, Rob Clark wrote: >> On Fri, Jan 25, 2013 at 8:15 AM, Mohammed, Afzal wrote: > >> > It's not about being simple, but not doing the wrong way, here you are >> > relying on a platform specific clo

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-28 Thread Mohammed, Afzal
Hi Rob, On Fri, Jan 25, 2013 at 20:22:55, Rob Clark wrote: > On Fri, Jan 25, 2013 at 8:15 AM, Mohammed, Afzal wrote: > > It's not about being simple, but not doing the wrong way, here you are > > relying on a platform specific clock in a driver, think about the case > > where same IP is used on

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-28 Thread Rob Clark
On Mon, Jan 28, 2013 at 3:56 AM, Mohammed, Afzal wrote: > Hi Rob, > > On Fri, Jan 25, 2013 at 20:22:55, Rob Clark wrote: >> On Fri, Jan 25, 2013 at 8:15 AM, Mohammed, Afzal wrote: > >> > It's not about being simple, but not doing the wrong way, here you are >> > relying on a platform specific clo

RE: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-28 Thread Mohammed, Afzal
Hi Rob, On Fri, Jan 25, 2013 at 20:22:55, Rob Clark wrote: > On Fri, Jan 25, 2013 at 8:15 AM, Mohammed, Afzal wrote: > > It's not about being simple, but not doing the wrong way, here you are > > relying on a platform specific clock in a driver, think about the case > > where same IP is used on

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Mohammed, Afzal
Hi Rob, On Fri, Jan 25, 2013 at 19:29:40, Rob Clark wrote: > On Fri, Jan 25, 2013 at 7:19 AM, Mohammed, Afzal wrote: > > On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: > >> A simple DRM/KMS driver for the TI LCD Controller found in various > >> smaller TI parts (AM33xx, OMAPL138, etc). This

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Mohammed, Afzal
Hi Rob, On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: > A simple DRM/KMS driver for the TI LCD Controller found in various > smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the > +void tilcdc_crtc_update_clk(struct drm_crtc *crtc) > + /* in raster mode, minimum divisor is 2

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Rob Clark
On Fri, Jan 25, 2013 at 8:15 AM, Mohammed, Afzal wrote: > Hi Rob, > > On Fri, Jan 25, 2013 at 19:29:40, Rob Clark wrote: >> On Fri, Jan 25, 2013 at 7:19 AM, Mohammed, Afzal wrote: >> > On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: > >> >> A simple DRM/KMS driver for the TI LCD Controller fou

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Rob Clark
On Fri, Jan 25, 2013 at 7:19 AM, Mohammed, Afzal wrote: > Hi Rob, > > On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: > >> A simple DRM/KMS driver for the TI LCD Controller found in various >> smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the > >> +void tilcdc_crtc_update_clk(stru

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Rob Clark
On Fri, Jan 25, 2013 at 8:15 AM, Mohammed, Afzal wrote: > Hi Rob, > > On Fri, Jan 25, 2013 at 19:29:40, Rob Clark wrote: >> On Fri, Jan 25, 2013 at 7:19 AM, Mohammed, Afzal wrote: >> > On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: > >> >> A simple DRM/KMS driver for the TI LCD Controller fou

RE: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Mohammed, Afzal
Hi Rob, On Fri, Jan 25, 2013 at 19:29:40, Rob Clark wrote: > On Fri, Jan 25, 2013 at 7:19 AM, Mohammed, Afzal wrote: > > On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: > >> A simple DRM/KMS driver for the TI LCD Controller found in various > >> smaller TI parts (AM33xx, OMAPL138, etc). This

RE: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Mohammed, Afzal
Hi Rob, On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: > A simple DRM/KMS driver for the TI LCD Controller found in various > smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the > +void tilcdc_crtc_update_clk(struct drm_crtc *crtc) > + /* in raster mode, minimum divisor is 2

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Rob Clark
On Fri, Jan 25, 2013 at 7:19 AM, Mohammed, Afzal wrote: > Hi Rob, > > On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: > >> A simple DRM/KMS driver for the TI LCD Controller found in various >> smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the > >> +void tilcdc_crtc_update_clk(stru

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Russell King - ARM Linux
On Wed, Jan 23, 2013 at 07:24:33AM -0600, Rob Clark wrote: > On Wed, Jan 23, 2013 at 3:42 AM, Jean-Francois Moine > wrote: > > Hi Rob, > > > > As I wanted to re-use your nxp-tda998x driver for the Marvell Dove SoC, > > I had a look at your IT LCD driver. Comments below. > > Just fyi, you can re-

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Jean-Francois Moine
Hi Rob, As I wanted to re-use your nxp-tda998x driver for the Marvell Dove SoC, I had a look at your IT LCD driver. Comments below. On Tue, 22 Jan 2013 16:36:22 -0600 Rob Clark wrote: > A simple DRM/KMS driver for the TI LCD Controller found in various > smaller TI parts (AM33xx, OMAPL138, etc)

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Koen Kooi
Op 22 jan. 2013, om 23:36 heeft Rob Clark het volgende geschreven: > A simple DRM/KMS driver for the TI LCD Controller found in various > smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the > CMA helpers. Currently only the TFP410 DVI encoder is supported > (tested with beaglebone

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Rob Clark
On Wed, Jan 23, 2013 at 8:13 AM, Rob Clark wrote: > On Wed, Jan 23, 2013 at 7:36 AM, Russell King - ARM Linux > wrote: >> On Wed, Jan 23, 2013 at 07:24:33AM -0600, Rob Clark wrote: >>> On Wed, Jan 23, 2013 at 3:42 AM, Jean-Francois Moine >>> wrote: >>> > Hi Rob, >>> > >>> > As I wanted to re-us

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Rob Clark
On Wed, Jan 23, 2013 at 7:36 AM, Russell King - ARM Linux wrote: > On Wed, Jan 23, 2013 at 07:24:33AM -0600, Rob Clark wrote: >> On Wed, Jan 23, 2013 at 3:42 AM, Jean-Francois Moine >> wrote: >> > Hi Rob, >> > >> > As I wanted to re-use your nxp-tda998x driver for the Marvell Dove SoC, >> > I ha

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Rob Clark
On Wed, Jan 23, 2013 at 3:42 AM, Jean-Francois Moine wrote: > Hi Rob, > > As I wanted to re-use your nxp-tda998x driver for the Marvell Dove SoC, > I had a look at your IT LCD driver. Comments below. Just fyi, you can re-use the nxp-tda998x part independently of tilcdc (just in case that wasn't c

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Rob Clark
On Wed, Jan 23, 2013 at 8:13 AM, Rob Clark wrote: > On Wed, Jan 23, 2013 at 7:36 AM, Russell King - ARM Linux > wrote: >> On Wed, Jan 23, 2013 at 07:24:33AM -0600, Rob Clark wrote: >>> On Wed, Jan 23, 2013 at 3:42 AM, Jean-Francois Moine >>> wrote: >>> > Hi Rob, >>> > >>> > As I wanted to re-us

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Russell King - ARM Linux
On Wed, Jan 23, 2013 at 07:24:33AM -0600, Rob Clark wrote: > On Wed, Jan 23, 2013 at 3:42 AM, Jean-Francois Moine wrote: > > Hi Rob, > > > > As I wanted to re-use your nxp-tda998x driver for the Marvell Dove SoC, > > I had a look at your IT LCD driver. Comments below. > > Just fyi, you can re-use

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Jean-Francois Moine
Hi Rob, As I wanted to re-use your nxp-tda998x driver for the Marvell Dove SoC, I had a look at your IT LCD driver. Comments below. On Tue, 22 Jan 2013 16:36:22 -0600 Rob Clark wrote: > A simple DRM/KMS driver for the TI LCD Controller found in various > smaller TI parts (AM33xx, OMAPL138, etc)

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Koen Kooi
Op 22 jan. 2013, om 23:36 heeft Rob Clark het volgende geschreven: > A simple DRM/KMS driver for the TI LCD Controller found in various > smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the > CMA helpers. Currently only the TFP410 DVI encoder is supported > (tested with beaglebone

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Rob Clark
On Wed, Jan 23, 2013 at 7:36 AM, Russell King - ARM Linux wrote: > On Wed, Jan 23, 2013 at 07:24:33AM -0600, Rob Clark wrote: >> On Wed, Jan 23, 2013 at 3:42 AM, Jean-Francois Moine wrote: >> > Hi Rob, >> > >> > As I wanted to re-use your nxp-tda998x driver for the Marvell Dove SoC, >> > I had a

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Rob Clark
On Wed, Jan 23, 2013 at 3:42 AM, Jean-Francois Moine wrote: > Hi Rob, > > As I wanted to re-use your nxp-tda998x driver for the Marvell Dove SoC, > I had a look at your IT LCD driver. Comments below. Just fyi, you can re-use the nxp-tda998x part independently of tilcdc (just in case that wasn't c

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Daniel Vetter
On Tue, Jan 22, 2013 at 04:36:22PM -0600, Rob Clark wrote: > A simple DRM/KMS driver for the TI LCD Controller found in various > smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the > CMA helpers. Currently only the TFP410 DVI encoder is supported > (tested with beaglebone + DVI cape).

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-22 Thread Rob Clark
A simple DRM/KMS driver for the TI LCD Controller found in various smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the CMA helpers. Currently only the TFP410 DVI encoder is supported (tested with beaglebone + DVI cape). There are also various LCD displays, for which support can be add

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-22 Thread Daniel Vetter
On Tue, Jan 22, 2013 at 04:36:22PM -0600, Rob Clark wrote: > A simple DRM/KMS driver for the TI LCD Controller found in various > smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the > CMA helpers. Currently only the TFP410 DVI encoder is supported > (tested with beaglebone + DVI cape).