[PATCH 1/4] drm/radeon: fix and simplify pot argument checks v2

2012-10-24 Thread Christian König
On 23.10.2012 18:45, Klaus Schnass wrote: >> /** >> + * radeon_check_pot_argument - check that argument is a power of two >> + * >> + * @arg: value to check >> + * >> + * Validates that a certain argument is a power of two (all asics). >> + * Returns true if argument is valid. >> + */ >> +static bo

[PATCH 1/4] drm/radeon: fix and simplify pot argument checks v2

2012-10-24 Thread Alex Deucher
On Wed, Oct 24, 2012 at 11:31 AM, Christian K?nig wrote: > On 23.10.2012 18:45, Klaus Schnass wrote: >>> >>> /** >>> + * radeon_check_pot_argument - check that argument is a power of two >>> + * >>> + * @arg: value to check >>> + * >>> + * Validates that a certain argument is a power of two (all a

Re: [PATCH 1/4] drm/radeon: fix and simplify pot argument checks v2

2012-10-24 Thread Alex Deucher
On Wed, Oct 24, 2012 at 11:31 AM, Christian König wrote: > On 23.10.2012 18:45, Klaus Schnass wrote: >>> >>> /** >>> + * radeon_check_pot_argument - check that argument is a power of two >>> + * >>> + * @arg: value to check >>> + * >>> + * Validates that a certain argument is a power of two (all a

Re: [PATCH 1/4] drm/radeon: fix and simplify pot argument checks v2

2012-10-24 Thread Christian König
On 23.10.2012 18:45, Klaus Schnass wrote: /** + * radeon_check_pot_argument - check that argument is a power of two + * + * @arg: value to check + * + * Validates that a certain argument is a power of two (all asics). + * Returns true if argument is valid. + */ +static bool radeon_ckeck_pot_argum

[PATCH 1/4] drm/radeon: fix and simplify pot argument checks v2

2012-10-23 Thread Klaus Schnass
> /** >+ * radeon_check_pot_argument - check that argument is a power of two >+ * >+ * @arg: value to check >+ * >+ * Validates that a certain argument is a power of two (all asics). >+ * Returns true if argument is valid. >+ */ >+static bool radeon_ckeck_pot_argument(int arg) >+{ >+ return (

[PATCH 1/4] drm/radeon: fix and simplify pot argument checks v2

2012-10-23 Thread Klaus Schnass
> /** >+ * radeon_check_pot_argument - check that argument is a power of two >+ * >+ * @arg: value to check >+ * >+ * Validates that a certain argument is a power of two (all asics). >+ * Returns true if argument is valid. >+ */ >+static bool radeon_ckeck_pot_argument(int arg) >+{ >+ return (

[PATCH 1/4] drm/radeon: fix and simplify pot argument checks v2

2012-10-23 Thread Michel Dänzer
On Die, 2012-10-23 at 15:53 +0200, Christian K?nig wrote: > GART and VRAM size limits need to be a power of two. > Fix values greater than 1GB and simplify those checks a bit. > > v2: also fix radeon_vram_limit usage, and simplify test even more. > > Signed-off-by: Christian K?nig Reviewed-by:

[PATCH 1/4] drm/radeon: fix and simplify pot argument checks v2

2012-10-23 Thread Christian König
GART and VRAM size limits need to be a power of two. Fix values greater than 1GB and simplify those checks a bit. v2: also fix radeon_vram_limit usage, and simplify test even more. Signed-off-by: Christian K?nig --- drivers/gpu/drm/radeon/radeon_device.c | 60 +---

[PATCH 1/4] drm/radeon: fix and simplify pot argument checks

2012-10-23 Thread Christian König
On 23.10.2012 14:44, Michel D?nzer wrote: > On Die, 2012-10-23 at 14:23 +0200, Christian K?nig wrote: >> GART and VRAM size limits need to be a power of two. >> Fix values greater than 1GB and simplify those checks a bit. >> >> Signed-off-by: Christian K?nig >> --- >> drivers/gpu/drm/radeon/rade

[PATCH 1/4] drm/radeon: fix and simplify pot argument checks

2012-10-23 Thread Michel Dänzer
On Die, 2012-10-23 at 14:23 +0200, Christian K?nig wrote: > GART and VRAM size limits need to be a power of two. > Fix values greater than 1GB and simplify those checks a bit. > > Signed-off-by: Christian K?nig > --- > drivers/gpu/drm/radeon/radeon_device.c | 55 > ---

[PATCH 1/4] drm/radeon: fix and simplify pot argument checks

2012-10-23 Thread Christian König
GART and VRAM size limits need to be a power of two. Fix values greater than 1GB and simplify those checks a bit. Signed-off-by: Christian K?nig --- drivers/gpu/drm/radeon/radeon_device.c | 55 1 file changed, 21 insertions(+), 34 deletions(-) diff --git a/dri

Re: [PATCH 1/4] drm/radeon: fix and simplify pot argument checks v2

2012-10-23 Thread Michel Dänzer
On Die, 2012-10-23 at 15:53 +0200, Christian König wrote: > GART and VRAM size limits need to be a power of two. > Fix values greater than 1GB and simplify those checks a bit. > > v2: also fix radeon_vram_limit usage, and simplify test even more. > > Signed-off-by: Christian König Reviewed-by:

[PATCH 1/4] drm/radeon: fix and simplify pot argument checks v2

2012-10-23 Thread Christian König
GART and VRAM size limits need to be a power of two. Fix values greater than 1GB and simplify those checks a bit. v2: also fix radeon_vram_limit usage, and simplify test even more. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_device.c | 60 +---

Re: [PATCH 1/4] drm/radeon: fix and simplify pot argument checks

2012-10-23 Thread Christian König
On 23.10.2012 14:44, Michel Dänzer wrote: On Die, 2012-10-23 at 14:23 +0200, Christian König wrote: GART and VRAM size limits need to be a power of two. Fix values greater than 1GB and simplify those checks a bit. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_device.c |

Re: [PATCH 1/4] drm/radeon: fix and simplify pot argument checks

2012-10-23 Thread Michel Dänzer
On Die, 2012-10-23 at 14:23 +0200, Christian König wrote: > GART and VRAM size limits need to be a power of two. > Fix values greater than 1GB and simplify those checks a bit. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/radeon/radeon_device.c | 55 > ---

[PATCH 1/4] drm/radeon: fix and simplify pot argument checks

2012-10-23 Thread Christian König
GART and VRAM size limits need to be a power of two. Fix values greater than 1GB and simplify those checks a bit. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_device.c | 55 1 file changed, 21 insertions(+), 34 deletions(-) diff --git a/dri