Re: [PATCH 1/4] drm/mipi-dbi: Support command mode panel drivers

2019-08-13 Thread Noralf Trønnes
Den 12.08.2019 20.49, skrev Sam Ravnborg: > Hi Noralf. > >>> - drm_panel has proper support for modes. >>> This is today duplicated in mipi_dbi. >>> Could we make it so that when a panel is used then the panel >>> has the mode info - as we then use the panel more in the way we do >>> in

Re: [PATCH 1/4] drm/mipi-dbi: Support command mode panel drivers

2019-08-12 Thread Sam Ravnborg
Hi Noralf. > > - drm_panel has proper support for modes. > > This is today duplicated in mipi_dbi. > > Could we make it so that when a panel is used then the panel > > has the mode info - as we then use the panel more in the way we do > > in other cases? > > As it is now the mode is spec

Re: [PATCH 1/4] drm/mipi-dbi: Support command mode panel drivers

2019-08-12 Thread Noralf Trønnes
Den 11.08.2019 16.16, skrev Sam Ravnborg: > Hi Noralf. > > I really like how this allows us to have a single file for all > the uses of a driver IC. > And this patch-set is much easier to grasp than the first RFC. > > General things: > > - The current design have a tight connection between the

Re: [PATCH 1/4] drm/mipi-dbi: Support command mode panel drivers

2019-08-11 Thread Sam Ravnborg
Hi Noralf. I really like how this allows us to have a single file for all the uses of a driver IC. And this patch-set is much easier to grasp than the first RFC. General things: - The current design have a tight connection between the display controller and the panel. Will this hurt in the lon

[PATCH 1/4] drm/mipi-dbi: Support command mode panel drivers

2019-08-01 Thread Noralf Trønnes
This adds a function that registers a DRM driver for use with MIPI DBI panels in command mode. That is, framebuffer upload over DBI. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_mipi_dbi.c | 92 ++ include/drm/drm_mipi_dbi.h | 34 + 2 file