Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

On Tue, Mar 06, 2018 at 08:29:20AM +0100, Daniel Vetter wrote: > On Wed, Feb 21, 2018 at 04:19:40PM +0100, Maarten Lankhorst wrote: > > Hey, > > > > Op 21-02-18 om 15:37 schreef Rob Clark: > > > Follow the same pattern of locking as with other state objects. This > > > avoids boilerplate in the d

Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

On Wed, Feb 21, 2018 at 06:36:54PM +0200, Ville Syrjälä wrote: > On Wed, Feb 21, 2018 at 11:17:21AM -0500, Rob Clark wrote: > > On Wed, Feb 21, 2018 at 10:54 AM, Ville Syrjälä > > wrote: > > > On Wed, Feb 21, 2018 at 10:36:06AM -0500, Rob Clark wrote: > > >> On Wed, Feb 21, 2018 at 10:27 AM, Ville

Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

On Wed, Feb 21, 2018 at 09:37:21AM -0500, Rob Clark wrote: > Follow the same pattern of locking as with other state objects. This > avoids boilerplate in the driver. > > Signed-off-by: Rob Clark Please also adjust the kernel doc, and I think we can remove the locking WARN_ON in drm_atomic_get_m

Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

On Wed, Feb 21, 2018 at 04:19:40PM +0100, Maarten Lankhorst wrote: > Hey, > > Op 21-02-18 om 15:37 schreef Rob Clark: > > Follow the same pattern of locking as with other state objects. This > > avoids boilerplate in the driver. > I'm afraid this will prohibit any uses of this on i915, since it s

Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

On Wed, Feb 21, 2018 at 11:36 AM, Ville Syrjälä wrote: > On Wed, Feb 21, 2018 at 11:17:21AM -0500, Rob Clark wrote: >> On Wed, Feb 21, 2018 at 10:54 AM, Ville Syrjälä >> wrote: >> > On Wed, Feb 21, 2018 at 10:36:06AM -0500, Rob Clark wrote: >> >> On Wed, Feb 21, 2018 at 10:27 AM, Ville Syrjälä >>

Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

On Wed, Feb 21, 2018 at 11:17:21AM -0500, Rob Clark wrote: > On Wed, Feb 21, 2018 at 10:54 AM, Ville Syrjälä > wrote: > > On Wed, Feb 21, 2018 at 10:36:06AM -0500, Rob Clark wrote: > >> On Wed, Feb 21, 2018 at 10:27 AM, Ville Syrjälä > >> wrote: > >> > On Wed, Feb 21, 2018 at 10:20:03AM -0500, Ro

Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

On Wed, Feb 21, 2018 at 10:54 AM, Ville Syrjälä wrote: > On Wed, Feb 21, 2018 at 10:36:06AM -0500, Rob Clark wrote: >> On Wed, Feb 21, 2018 at 10:27 AM, Ville Syrjälä >> wrote: >> > On Wed, Feb 21, 2018 at 10:20:03AM -0500, Rob Clark wrote: >> >> On Wed, Feb 21, 2018 at 10:07 AM, Ville Syrjälä >>

Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

On Wed, Feb 21, 2018 at 10:36:06AM -0500, Rob Clark wrote: > On Wed, Feb 21, 2018 at 10:27 AM, Ville Syrjälä > wrote: > > On Wed, Feb 21, 2018 at 10:20:03AM -0500, Rob Clark wrote: > >> On Wed, Feb 21, 2018 at 10:07 AM, Ville Syrjälä > >> wrote: > >> > On Wed, Feb 21, 2018 at 09:54:49AM -0500, Ro

Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

On Wed, Feb 21, 2018 at 10:27 AM, Ville Syrjälä wrote: > On Wed, Feb 21, 2018 at 10:20:03AM -0500, Rob Clark wrote: >> On Wed, Feb 21, 2018 at 10:07 AM, Ville Syrjälä >> wrote: >> > On Wed, Feb 21, 2018 at 09:54:49AM -0500, Rob Clark wrote: >> >> On Wed, Feb 21, 2018 at 9:49 AM, Ville Syrjälä >>

Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

On Wed, Feb 21, 2018 at 10:20:03AM -0500, Rob Clark wrote: > On Wed, Feb 21, 2018 at 10:07 AM, Ville Syrjälä > wrote: > > On Wed, Feb 21, 2018 at 09:54:49AM -0500, Rob Clark wrote: > >> On Wed, Feb 21, 2018 at 9:49 AM, Ville Syrjälä > >> wrote: > >> > On Wed, Feb 21, 2018 at 09:37:21AM -0500, Rob

Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

On Wed, Feb 21, 2018 at 10:07 AM, Ville Syrjälä wrote: > On Wed, Feb 21, 2018 at 09:54:49AM -0500, Rob Clark wrote: >> On Wed, Feb 21, 2018 at 9:49 AM, Ville Syrjälä >> wrote: >> > On Wed, Feb 21, 2018 at 09:37:21AM -0500, Rob Clark wrote: >> >> Follow the same pattern of locking as with other st

Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

Hey, Op 21-02-18 om 15:37 schreef Rob Clark: > Follow the same pattern of locking as with other state objects. This > avoids boilerplate in the driver. I'm afraid this will prohibit any uses of this on i915, since it still uses legacy lock_all(). Oh well, afaict nothing in i915 uses private obj

Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

On Wed, Feb 21, 2018 at 09:54:49AM -0500, Rob Clark wrote: > On Wed, Feb 21, 2018 at 9:49 AM, Ville Syrjälä > wrote: > > On Wed, Feb 21, 2018 at 09:37:21AM -0500, Rob Clark wrote: > >> Follow the same pattern of locking as with other state objects. This > >> avoids boilerplate in the driver. > >

Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

On Wed, Feb 21, 2018 at 9:49 AM, Ville Syrjälä wrote: > On Wed, Feb 21, 2018 at 09:37:21AM -0500, Rob Clark wrote: >> Follow the same pattern of locking as with other state objects. This >> avoids boilerplate in the driver. > > I'm not sure we really want to do this. What if the driver wants a >

Re: [PATCH 1/4] drm/atomic: integrate modeset lock with private objects

On Wed, Feb 21, 2018 at 09:37:21AM -0500, Rob Clark wrote: > Follow the same pattern of locking as with other state objects. This > avoids boilerplate in the driver. I'm not sure we really want to do this. What if the driver wants a custom locking scheme for this state? > > Signed-off-by: Rob C

[PATCH 1/4] drm/atomic: integrate modeset lock with private objects

Follow the same pattern of locking as with other state objects. This avoids boilerplate in the driver. Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_atomic.c | 9 - include/drm/drm_atomic.h | 5 + 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/