Re: [PATCH 1/3 v2] drm: rcar-du: add missing of_node_put

2019-01-14 Thread Kieran Bingham
Hi Julia, On 14/01/2019 16:44, Julia Lawall wrote: > Add an of_node_put when the result of of_graph_get_remote_port_parent is > not available. > > Add a second of_node_put if no encoder is selected (encoder remains NULL). > > The semantic match that finds the first problem is as follows > (http:

Re: [PATCH 1/3 v2] drm: rcar-du: add missing of_node_put

2019-01-14 Thread Laurent Pinchart
Hi Julia, Thank you for the patch. On Monday, 14 January 2019 18:44:56 EET Julia Lawall wrote: > Add an of_node_put when the result of of_graph_get_remote_port_parent is > not available. > > Add a second of_node_put if no encoder is selected (encoder remains NULL). > > The semantic match that f

[PATCH 1/3 v2] drm: rcar-du: add missing of_node_put

2019-01-14 Thread Julia Lawall
Add an of_node_put when the result of of_graph_get_remote_port_parent is not available. Add a second of_node_put if no encoder is selected (encoder remains NULL). The semantic match that finds the first problem is as follows (http://coccinelle.lip6.fr): // @r exists@ local idexpression e; expre