RE: [PATCH 1/3] mm: Export vmf_insert_mixed_mkwrite()

2025-04-10 Thread Michael Kelley
From: Christoph Hellwig Sent: Thursday, April 10, 2025 12:42 AM > > On Wed, Apr 09, 2025 at 02:10:26PM +, Michael Kelley wrote: > > Hmmm. What's the reference to "as told last time"? I don't think I've had > > this conversation before. > > Hmm, there was a conversation about deferred I/O, an

Re: [PATCH 1/3] mm: Export vmf_insert_mixed_mkwrite()

2025-04-10 Thread Christoph Hellwig
On Wed, Apr 09, 2025 at 02:10:26PM +, Michael Kelley wrote: > Hmmm. What's the reference to "as told last time"? I don't think I've had > this conversation before. Hmm, there was a conversation about deferred I/O, and I remember the drm folks even defending their abuse of vmalloc_to_page on dm

RE: [PATCH 1/3] mm: Export vmf_insert_mixed_mkwrite()

2025-04-09 Thread Michael Kelley
From: Christoph Hellwig Sent: Wednesday, April 9, 2025 3:50 AM > > On Tue, Apr 08, 2025 at 11:36:44AM -0700, mhkelle...@gmail.com wrote: > > From: Michael Kelley > > > > Export vmf_insert_mixed_mkwrite() for use by fbdev deferred I/O code, > > But they are using this on dma coherent memory, whe

Re: [PATCH 1/3] mm: Export vmf_insert_mixed_mkwrite()

2025-04-09 Thread Christoph Hellwig
On Tue, Apr 08, 2025 at 11:36:44AM -0700, mhkelle...@gmail.com wrote: > From: Michael Kelley > > Export vmf_insert_mixed_mkwrite() for use by fbdev deferred I/O code, But they are using this on dma coherent memory, where you can't legally get at the page. As told last time you need to fix that

[PATCH 1/3] mm: Export vmf_insert_mixed_mkwrite()

2025-04-08 Thread mhkelley58
From: Michael Kelley Export vmf_insert_mixed_mkwrite() for use by fbdev deferred I/O code, which can be built as a module. For consistency with the related function vmf_insert_mixed(), export without the GPL qualifier. Commit cd1e0dac3a3e ("mm: unexport vmf_insert_mixed_mkwrite") is effectively