[PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-13 Thread Dave Airlie
> > Ok, thanks for explanation. I'll drop this patch and rebase the others. Cool, >> You won't be able to make this work for vga16fb from what I can see >> since it access 0xa000 directly, not via any of the defined apertures >> that vesafb/offb use. vga16fb will need a different approach I suspe

[PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-13 Thread Dave Airlie
On Mon, 2010-04-12 at 13:34 +0200, Marcin Slusarz wrote: > On Mon, Apr 12, 2010 at 09:54:28AM +1000, Dave Airlie wrote: > > On Sat, 2010-04-10 at 21:55 +0200, marcin.slusarz at gmail.com wrote: > > > fb_do_apertures_overlap is returning wrong value when one aperture > > > is completely whithin the

[PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-12 Thread Marcin Slusarz
On Tue, Apr 13, 2010 at 06:28:21AM +1000, Dave Airlie wrote: > On Mon, 2010-04-12 at 13:34 +0200, Marcin Slusarz wrote: > > On Mon, Apr 12, 2010 at 09:54:28AM +1000, Dave Airlie wrote: > > > On Sat, 2010-04-10 at 21:55 +0200, marcin.slusarz at gmail.com wrote: > > > > fb_do_apertures_overlap is ret

Re: [PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-12 Thread Dave Airlie
> > Ok, thanks for explanation. I'll drop this patch and rebase the others. Cool, >> You won't be able to make this work for vga16fb from what I can see >> since it access 0xa000 directly, not via any of the defined apertures >> that vesafb/offb use. vga16fb will need a different approach I suspe

Re: [PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-12 Thread Marcin Slusarz
On Tue, Apr 13, 2010 at 06:28:21AM +1000, Dave Airlie wrote: > On Mon, 2010-04-12 at 13:34 +0200, Marcin Slusarz wrote: > > On Mon, Apr 12, 2010 at 09:54:28AM +1000, Dave Airlie wrote: > > > On Sat, 2010-04-10 at 21:55 +0200, marcin.slus...@gmail.com wrote: > > > > fb_do_apertures_overlap is return

[PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-12 Thread Marcin Slusarz
On Mon, Apr 12, 2010 at 09:54:28AM +1000, Dave Airlie wrote: > On Sat, 2010-04-10 at 21:55 +0200, marcin.slusarz at gmail.com wrote: > > fb_do_apertures_overlap is returning wrong value when one aperture > > is completely whithin the other. Add generic ranges_overlap macro > > (probably kernel.h ca

Re: [PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-12 Thread Dave Airlie
On Mon, 2010-04-12 at 13:34 +0200, Marcin Slusarz wrote: > On Mon, Apr 12, 2010 at 09:54:28AM +1000, Dave Airlie wrote: > > On Sat, 2010-04-10 at 21:55 +0200, marcin.slus...@gmail.com wrote: > > > fb_do_apertures_overlap is returning wrong value when one aperture > > > is completely whithin the oth

[PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-12 Thread Dave Airlie
On Sat, 2010-04-10 at 21:55 +0200, marcin.slusarz at gmail.com wrote: > fb_do_apertures_overlap is returning wrong value when one aperture > is completely whithin the other. Add generic ranges_overlap macro > (probably kernel.h candidate) and use it here. > That doesn't seem right. The rules are

Re: [PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-12 Thread Marcin Slusarz
On Mon, Apr 12, 2010 at 09:54:28AM +1000, Dave Airlie wrote: > On Sat, 2010-04-10 at 21:55 +0200, marcin.slus...@gmail.com wrote: > > fb_do_apertures_overlap is returning wrong value when one aperture > > is completely whithin the other. Add generic ranges_overlap macro > > (probably kernel.h candi

Re: [PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-11 Thread Dave Airlie
On Sat, 2010-04-10 at 21:55 +0200, marcin.slus...@gmail.com wrote: > fb_do_apertures_overlap is returning wrong value when one aperture > is completely whithin the other. Add generic ranges_overlap macro > (probably kernel.h candidate) and use it here. > That doesn't seem right. The rules are:

[PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-10 Thread marcin.slus...@gmail.com
fb_do_apertures_overlap is returning wrong value when one aperture is completely whithin the other. Add generic ranges_overlap macro (probably kernel.h candidate) and use it here. Signed-off-by: Marcin Slusarz Cc: Dave Airlie Cc: Peter Jones Cc: Andrew Morton --- drivers/video/fbmem.c | 24

[PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-10 Thread marcin . slusarz
fb_do_apertures_overlap is returning wrong value when one aperture is completely whithin the other. Add generic ranges_overlap macro (probably kernel.h candidate) and use it here. Signed-off-by: Marcin Slusarz Cc: Dave Airlie Cc: Peter Jones Cc: Andrew Morton --- drivers/video/fbmem.c | 24