RE: [PATCH 1/3] drm: add writeback pointers to drm_connector

2022-01-31 Thread Kandpal, Suraj
Hey, > I think there are more places affected with this change. I can get below > compilation issues while trying to compile my branch: > > drivers/gpu/drm/vc4/vc4_txp.c: In function ‘encoder_to_vc4_txp’: > ./include/linux/build_bug.h:78:41: error: static assertion failed: > "pointer type mismatch

Re: [PATCH 1/3] drm: add writeback pointers to drm_connector

2022-01-31 Thread Abhinav Kumar
Hi Suraj I think there are more places affected with this change. I can get below compilation issues while trying to compile my branch: drivers/gpu/drm/vc4/vc4_txp.c: In function ‘encoder_to_vc4_txp’: ./include/linux/build_bug.h:78:41: error: static assertion failed: "pointer type mismatch in

Re: [PATCH 1/3] drm: add writeback pointers to drm_connector

2022-01-27 Thread Abhinav Kumar
Hi Suraj Thanks for the response. I was not too worried about the intel driver as I am sure you must have validated this change with that :) My question was more for the other vendor writeback drivers. Thanks for looking into the others and providing the snippets. After looking at those, yes

RE: [PATCH 1/3] drm: add writeback pointers to drm_connector

2022-01-27 Thread Kandpal, Suraj
> > + laurent on this > > Hi Suraj > Jani pointed me to this thread as i had posted something similar here : > https://patchwork.freedesktop.org/patch/470296/ but since this thread was > posted earlier, we can discuss further here. > > Overall, its similar to what I had posted in the RFC and you

Re: [PATCH 1/3] drm: add writeback pointers to drm_connector

2022-01-21 Thread Abhinav Kumar
+ laurent on this Hi Suraj On 1/11/2022 2:17 AM, Kandpal, Suraj wrote: Changing drm_connector and drm_encoder feilds to pointers in drm_writeback_connector as the elements of struct drm_writeback_connector are: struct drm_writeback_connector { struct drm_connector base; struct d

[PATCH 1/3] drm: add writeback pointers to drm_connector

2022-01-11 Thread Kandpal, Suraj
Changing drm_connector and drm_encoder feilds to pointers in drm_writeback_connector as the elements of struct drm_writeback_connector are: struct drm_writeback_connector { struct drm_connector base; struct drm_encoder encoder; Similarly the elements of intel_encoder and intel_conne