Re: [PATCH 1/3] drm/virtio: set seqno for dma-fence

2019-05-06 Thread Gerd Hoffmann
On Mon, Apr 29, 2019 at 03:08:23PM -0700, Chia-I Wu wrote: > This is motivated by having meaningful ftrace events, but it also > fixes use cases where dma_fence_is_later is called, such as in > sync_file_merge. > > In other drivers, fence creation and cmdbuf submission normally > happen atomically

Re: [PATCH 1/3] drm/virtio: set seqno for dma-fence

2019-05-03 Thread Emil Velikov
Hi Chia-I, On Mon, 29 Apr 2019 at 23:08, Chia-I Wu wrote: > > This is motivated by having meaningful ftrace events, but it also > fixes use cases where dma_fence_is_later is called, such as in > sync_file_merge. > > In other drivers, fence creation and cmdbuf submission normally > happen atomical

Re: [PATCH 1/3] drm/virtio: set seqno for dma-fence

2019-05-02 Thread Chia-I Wu
(Add missing CCs) On Mon, Apr 29, 2019 at 3:08 PM Chia-I Wu wrote: > > This is motivated by having meaningful ftrace events, but it also > fixes use cases where dma_fence_is_later is called, such as in > sync_file_merge. > > In other drivers, fence creation and cmdbuf submission normally > happe

[PATCH 1/3] drm/virtio: set seqno for dma-fence

2019-04-29 Thread Chia-I Wu
This is motivated by having meaningful ftrace events, but it also fixes use cases where dma_fence_is_later is called, such as in sync_file_merge. In other drivers, fence creation and cmdbuf submission normally happen atomically, mutex_lock(); fence = dma_fence_create(..., ++timeline->seqno);