Re: [Intel-gfx] [PATCH 1/3] drm/vblank: Document and fix vblank count barrier semantics

2019-07-19 Thread Ville Syrjälä
On Fri, Jul 19, 2019 at 08:33:49PM +0200, Daniel Vetter wrote: > On Fri, Jul 19, 2019 at 7:06 PM Ville Syrjälä > wrote: > > > > On Fri, Jul 19, 2019 at 05:23:12PM +0200, Daniel Vetter wrote: > > > Noticed while reviewing code. I'm not sure whether this might or might > > > not explain some of the

Re: [Intel-gfx] [PATCH 1/3] drm/vblank: Document and fix vblank count barrier semantics

2019-07-19 Thread Daniel Vetter
On Fri, Jul 19, 2019 at 7:06 PM Ville Syrjälä wrote: > > On Fri, Jul 19, 2019 at 05:23:12PM +0200, Daniel Vetter wrote: > > Noticed while reviewing code. I'm not sure whether this might or might > > not explain some of the missed vblank hilarity we've been seeing. I > > think those all go through

Re: [Intel-gfx] [PATCH 1/3] drm/vblank: Document and fix vblank count barrier semantics

2019-07-19 Thread Ville Syrjälä
On Fri, Jul 19, 2019 at 05:23:12PM +0200, Daniel Vetter wrote: > Noticed while reviewing code. I'm not sure whether this might or might > not explain some of the missed vblank hilarity we've been seeing. I > think those all go through the vblank completion event, which has > unconditional barriers

[PATCH 1/3] drm/vblank: Document and fix vblank count barrier semantics

2019-07-19 Thread Daniel Vetter
Noticed while reviewing code. I'm not sure whether this might or might not explain some of the missed vblank hilarity we've been seeing. I think those all go through the vblank completion event, which has unconditional barriers - it always takes the spinlock. Therefore no cc stable. v2: - Barrrier