Re: [PATCH 1/3] drm/plane: Mention format_mod_supported in IN_FORMATS docs

2021-12-21 Thread Simon Ser
On Tuesday, December 21st, 2021 at 13:33, Dmitry Baryshkov wrote: > I'd still suggest to fix create_in_format_blob() Yeah, I agree. I thought there were a good reason why create_in_format_blob() behaves this way but can't find anything in the Git history, so fixing it to behave as the documenta

Re: [PATCH 1/3] drm/plane: Mention format_mod_supported in IN_FORMATS docs

2021-12-21 Thread Dmitry Baryshkov
On Tue, 21 Dec 2021 at 13:50, Simon Ser wrote: > > On Tuesday, December 21st, 2021 at 11:48, Dmitry Baryshkov > wrote: > > > I think the fix should be applied to the generic code. > > Related: > https://lore.kernel.org/dri-devel/t1g_xNE6hgj1nTQfx2UWob1wbsCAxElBvWRwNSY_EzmlEe_9WWpq8-vQKyJPK6wZY8q

Re: [PATCH 1/3] drm/plane: Mention format_mod_supported in IN_FORMATS docs

2021-12-21 Thread Simon Ser
On Tuesday, December 21st, 2021 at 11:48, Dmitry Baryshkov wrote: > I think the fix should be applied to the generic code. Related: https://lore.kernel.org/dri-devel/t1g_xNE6hgj1nTQfx2UWob1wbsCAxElBvWRwNSY_EzmlEe_9WWpq8-vQKyJPK6wZY8q8BqHl-KoGwS5V91VgN8lGIl3PJt7s2fkdsRd3y70=@emersion.fr/T/#u

Re: [PATCH 1/3] drm/plane: Mention format_mod_supported in IN_FORMATS docs

2021-12-21 Thread Dmitry Baryshkov
On Tue, 21 Dec 2021 at 13:13, José Expósito wrote: > > Adding format modifiers without implementing the function > "drm_plane_funcs.format_mod_supported" exposes an invalid IN_FORMATS > blob with modifiers but no formats to user-space. I think the fix should be applied to the generic code. The do

Re: [PATCH 1/3] drm/plane: Mention format_mod_supported in IN_FORMATS docs

2021-12-21 Thread Simon Ser
Reviewed-by: Simon Ser Please ping me in a week or so if nobody objected and this isn't merged.

[PATCH 1/3] drm/plane: Mention format_mod_supported in IN_FORMATS docs

2021-12-21 Thread José Expósito
Adding format modifiers without implementing the function "drm_plane_funcs.format_mod_supported" exposes an invalid IN_FORMATS blob with modifiers but no formats to user-space. This breaks the latest Weston [1]. For testing purposes, I extracted the affected code to a standalone program [2]. Make