Re: [PATCH 1/3] drm/omap: fix uninitialized ret variable

2018-04-03 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Thursday, 29 March 2018 13:40:36 EEST Tomi Valkeinen wrote: > audio_config function for both HDMI4 and HDMI5 return uninitialized > value as the error code if the display is not currently enabled. For > some reason this has not caused any issues. > > Signed-o

Re: [PATCH 1/3] drm/omap: fix uninitialized ret variable

2018-03-29 Thread Tomi Valkeinen
On 29/03/18 13:58, Emil Velikov wrote: > On 29 March 2018 at 11:40, Tomi Valkeinen wrote: >> audio_config function for both HDMI4 and HDMI5 return uninitialized >> value as the error code if the display is not currently enabled. For >> some reason this has not caused any issues. >> > Doubt many pe

Re: [PATCH 1/3] drm/omap: fix uninitialized ret variable

2018-03-29 Thread Emil Velikov
On 29 March 2018 at 11:40, Tomi Valkeinen wrote: > audio_config function for both HDMI4 and HDMI5 return uninitialized > value as the error code if the display is not currently enabled. For > some reason this has not caused any issues. > Doubt many people try hdmi audio with disabled display ;-)

[PATCH 1/3] drm/omap: fix uninitialized ret variable

2018-03-29 Thread Tomi Valkeinen
audio_config function for both HDMI4 and HDMI5 return uninitialized value as the error code if the display is not currently enabled. For some reason this has not caused any issues. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 2 +- drivers/gpu/drm/omapdrm/dss/hdmi5.c |