Re: [PATCH 1/3] drm/edid: add drm_edid_duplicate

2013-09-27 Thread Damien Lespiau
On Fri, Sep 27, 2013 at 03:08:27PM +0300, Jani Nikula wrote: > We have some code duplication related to EDID duplication. Add a helper. git grep kmemdup.*edid drivers/gpu/drm/ also returns 3 hits in nouveau here, should anyone be bored. -- Damien ___ d

Re: [PATCH 1/3] drm/edid: add drm_edid_duplicate

2013-09-27 Thread Chris Wilson
On Fri, Sep 27, 2013 at 03:08:27PM +0300, Jani Nikula wrote: > We have some code duplication related to EDID duplication. Add a helper. Lgtm, debated the merits of assuming GFP_KERNEL and inlining, then thought better of it. All 3, Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open S

[PATCH 1/3] drm/edid: add drm_edid_duplicate

2013-09-27 Thread Jani Nikula
We have some code duplication related to EDID duplication. Add a helper. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 12 include/drm/drm_crtc.h |1 + 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c ind