Re: [PATCH 1/3] drm/bridge/synopsys: Add MIPI DSI2 host controller bridge

2024-11-26 Thread Heiko Stübner
Hi, Am Mittwoch, 6. November 2024, 14:54:39 CET schrieb neil.armstr...@linaro.org: > > +#define UPDATE(v, h, l)(((v) << (l)) & GENMASK((h), > > (l))) > > I'm not super fan of this macro, overall I thinkg you should switch to > regmap and make use of regmap_update_bits and dro

Re: [PATCH 1/3] drm/bridge/synopsys: Add MIPI DSI2 host controller bridge

2024-11-06 Thread Diederik de Haas
On Wed Nov 6, 2024 at 1:33 PM CET, Heiko Stuebner wrote: > From: Heiko Stuebner > > Add a Synopsys Designware MIPI DSI host DRM bridge driver for their > DSI2 host controller, based on the Rockchip version from the driver > rockchip/dw-mipi-dsi2.c in their vendor-kernel with phy & bridge APIs. > >

Re: [PATCH 1/3] drm/bridge/synopsys: Add MIPI DSI2 host controller bridge

2024-11-06 Thread neil . armstrong
Hi, On 06/11/2024 13:33, Heiko Stuebner wrote: From: Heiko Stuebner Add a Synopsys Designware MIPI DSI host DRM bridge driver for their DSI2 host controller, based on the Rockchip version from the driver rockchip/dw-mipi-dsi2.c in their vendor-kernel with phy & bridge APIs. While the driver i

[PATCH 1/3] drm/bridge/synopsys: Add MIPI DSI2 host controller bridge

2024-11-06 Thread Heiko Stuebner
From: Heiko Stuebner Add a Synopsys Designware MIPI DSI host DRM bridge driver for their DSI2 host controller, based on the Rockchip version from the driver rockchip/dw-mipi-dsi2.c in their vendor-kernel with phy & bridge APIs. While the driver is heavily modelled after the previous IP, the regi