Re: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

2018-01-05 Thread Harry Wentland
On 2018-01-04 04:11 PM, Samuel Li wrote: > From: Christian König > > On CZ and newer APUs we can pin the fb into GART as well as VRAM. > > v2: Don't enable gpu_vm_support for Raven yet since it leads to > a black screen. Need to debug this further before enabling. > > Change-Id: Id0f8af3110

Re: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

2018-01-05 Thread Harry Wentland
On 2018-01-04 04:11 PM, Samuel Li wrote: > From: Christian König > > On CZ and newer APUs we can pin the fb into GART as well as VRAM. > > v2: Don't enable gpu_vm_support for Raven yet since it leads to > a black screen. Need to debug this further before enabling. I can't find the part to e

Re: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

2018-01-05 Thread Harry Wentland
> >> -Original Message- >> From: Wentland, Harry >> Sent: Friday, January 05, 2018 10:50 AM >> To: Li, Samuel ; dri-devel@lists.freedesktop.org; >> amd-...@lists.freedesktop.org >> Cc: Koenig, Christian >> Subject: Re: [PATCH 1/3] drm/amdgpu:

RE: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

2018-01-05 Thread Li, Samuel
10:50 AM > To: Li, Samuel ; dri-devel@lists.freedesktop.org; > amd-...@lists.freedesktop.org > Cc: Koenig, Christian > Subject: Re: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory > as well > > On 2018-01-04 04:11 PM, Samuel Li wrote: > > From: Christian König >

Re: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

2018-01-05 Thread Samuel Li
> to make all the files use consistent naming going forward to make the code > more > readable. OK. Will do. Sam On 2018-01-04 05:43 PM, Alex Deucher wrote: > On Thu, Jan 4, 2018 at 5:26 PM, Samuel Li wrote: +uint32_t amdgpu_framebuffer_domains(struct amdgpu_device *adev) >>> >>> Please r

Re: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

2018-01-05 Thread Christian König
Am 04.01.2018 um 23:43 schrieb Alex Deucher: On Thu, Jan 4, 2018 at 5:26 PM, Samuel Li wrote: +uint32_t amdgpu_framebuffer_domains(struct amdgpu_device *adev) Please rename this amdgpu_display_framebuffer_domains() for consistency. Currently all the functions in this file are named without _d

Re: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

2018-01-04 Thread Alex Deucher
On Thu, Jan 4, 2018 at 5:26 PM, Samuel Li wrote: >>> +uint32_t amdgpu_framebuffer_domains(struct amdgpu_device *adev) >> >> Please rename this amdgpu_display_framebuffer_domains() for consistency. > Currently all the functions in this file are named without _display_. Am I > missing something? T

Re: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

2018-01-04 Thread Samuel Li
>> +uint32_t amdgpu_framebuffer_domains(struct amdgpu_device *adev) > > Please rename this amdgpu_display_framebuffer_domains() for consistency. Currently all the functions in this file are named without _display_. Am I missing something? >> + if (plane->type != DRM_PLANE_TYPE_CURSOR) > >

[PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

2018-01-04 Thread Samuel Li
From: Christian König On CZ and newer APUs we can pin the fb into GART as well as VRAM. v2: Don't enable gpu_vm_support for Raven yet since it leads to a black screen. Need to debug this further before enabling. Change-Id: Id0f8af3110e54a3aabf7a258871867bc121cc1a2 Signed-off-by: Christian K

Re: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

2018-01-04 Thread Alex Deucher
On Thu, Jan 4, 2018 at 4:11 PM, Samuel Li wrote: > From: Christian König > > On CZ and newer APUs we can pin the fb into GART as well as VRAM. > > v2: Don't enable gpu_vm_support for Raven yet since it leads to > a black screen. Need to debug this further before enabling. > > Change-Id: Id0f8