Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-21 Thread Johan Hovold
On Wed, Nov 15, 2017 at 03:39:09PM +0100, Johan Hovold wrote: > On Wed, Nov 15, 2017 at 02:32:11PM +, Lee Jones wrote: > > On Wed, 15 Nov 2017, Johan Hovold wrote: > > > > > On Tue, Nov 14, 2017 at 07:48:09PM +, Daniel Thompson wrote: > > > > On 14/11/17 18:05, Johan Hovold wrote: > > > >

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-20 Thread Lee Jones
On Mon, 20 Nov 2017, Johan Hovold wrote: > On Wed, Nov 15, 2017 at 03:39:09PM +0100, Johan Hovold wrote: > > On Wed, Nov 15, 2017 at 02:32:11PM +, Lee Jones wrote: > > > On Wed, 15 Nov 2017, Johan Hovold wrote: > > > > > > > On Tue, Nov 14, 2017 at 07:48:09PM +, Daniel Thompson wrote: > >

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-16 Thread Johan Hovold
On Wed, Nov 15, 2017 at 02:32:11PM +, Lee Jones wrote: > On Wed, 15 Nov 2017, Johan Hovold wrote: > > > On Tue, Nov 14, 2017 at 07:48:09PM +, Daniel Thompson wrote: > > > On 14/11/17 18:05, Johan Hovold wrote: > > > > On Mon, Nov 13, 2017 at 02:16:09PM +, Daniel Thompson wrote: > > > >

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-16 Thread Johan Hovold
On Tue, Nov 14, 2017 at 07:48:09PM +, Daniel Thompson wrote: > On 14/11/17 18:05, Johan Hovold wrote: > > On Mon, Nov 13, 2017 at 02:16:09PM +, Daniel Thompson wrote: > >> On 13/11/17 10:20, Johan Hovold wrote: > >>> Fix child-node lookup during probe, which ended up searching the whole > >

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-15 Thread Lee Jones
On Wed, 15 Nov 2017, Johan Hovold wrote: > On Tue, Nov 14, 2017 at 07:48:09PM +, Daniel Thompson wrote: > > On 14/11/17 18:05, Johan Hovold wrote: > > > On Mon, Nov 13, 2017 at 02:16:09PM +, Daniel Thompson wrote: > > >> On 13/11/17 10:20, Johan Hovold wrote: > > >>> Fix child-node lookup

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-15 Thread Johan Hovold
On Mon, Nov 13, 2017 at 02:16:09PM +, Daniel Thompson wrote: > On 13/11/17 10:20, Johan Hovold wrote: > > Fix child-node lookup during probe, which ended up searching the whole > > device tree depth-first starting at the parent rather than just matching > > on its children. > > > > To make thi

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-14 Thread Daniel Thompson
On 14/11/17 18:05, Johan Hovold wrote: On Mon, Nov 13, 2017 at 02:16:09PM +, Daniel Thompson wrote: On 13/11/17 10:20, Johan Hovold wrote: Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its c

[PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-13 Thread Johan Hovold
Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children. To make things worse, the parent mfd node was also prematurely freed. Note that the nodes returned from the two calls to of_parse_phandl

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-13 Thread Daniel Thompson
On 13/11/17 10:20, Johan Hovold wrote: Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children. To make things worse, the parent mfd node was also prematurely freed. Note that the nodes ret