Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-15 Thread Andrzej Hajda
On 11.07.2019 16:50, Mark Brown wrote: > On Thu, Jul 11, 2019 at 03:11:56PM +0200, Andrzej Hajda wrote: > >> 1. DSI protocol defines actually more than 30 types of transactions[1], >> but this patchset implements only few of them (dsi generic write/read >> family). Is it possible to implement multi

Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-12 Thread Rob Clark
On Fri, Jul 12, 2019 at 7:22 AM Jeffrey Hugo wrote: > > On Fri, Jul 12, 2019 at 7:01 AM Andrzej Hajda wrote: > > > > On 11.07.2019 15:56, Rob Clark wrote: > > > On Thu, Jul 11, 2019 at 6:11 AM Andrzej Hajda wrote: > > >> On 06.07.2019 03:06, Mark Brown wrote: > > >>> On Wed, Jul 03, 2019 at 02:4

Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-12 Thread Jeffrey Hugo
On Fri, Jul 12, 2019 at 7:01 AM Andrzej Hajda wrote: > > On 11.07.2019 15:56, Rob Clark wrote: > > On Thu, Jul 11, 2019 at 6:11 AM Andrzej Hajda wrote: > >> On 06.07.2019 03:06, Mark Brown wrote: > >>> On Wed, Jul 03, 2019 at 02:45:12PM -0700, Jeffrey Hugo wrote: > Add basic support with a s

Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-12 Thread Andrzej Hajda
On 11.07.2019 15:56, Rob Clark wrote: > On Thu, Jul 11, 2019 at 6:11 AM Andrzej Hajda wrote: >> On 06.07.2019 03:06, Mark Brown wrote: >>> On Wed, Jul 03, 2019 at 02:45:12PM -0700, Jeffrey Hugo wrote: Add basic support with a simple implementation that utilizes the generic read/write com

Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-11 Thread Mark Brown
On Thu, Jul 11, 2019 at 03:11:56PM +0200, Andrzej Hajda wrote: > 1. DSI protocol defines actually more than 30 types of transactions[1], > but this patchset implements only few of them (dsi generic write/read > family). Is it possible to implement multiple types of transactions in > regmap? You c

Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-11 Thread Mark Brown
On Wed, Jul 10, 2019 at 12:08:34PM -0600, Jeffrey Hugo wrote: > On Fri, Jul 5, 2019 at 7:06 PM Mark Brown wrote: > The addresses for these spec defined messages are 8-bit wide, so 256 > valid "destinations". However, the payload is variable. Most of the > defined operations take an 8-bit payloa

Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-11 Thread Rob Clark
On Thu, Jul 11, 2019 at 6:11 AM Andrzej Hajda wrote: > > On 06.07.2019 03:06, Mark Brown wrote: > > On Wed, Jul 03, 2019 at 02:45:12PM -0700, Jeffrey Hugo wrote: > >> Add basic support with a simple implementation that utilizes the generic > >> read/write commands to allow device registers to be c

Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-11 Thread Andrzej Hajda
On 06.07.2019 03:06, Mark Brown wrote: > On Wed, Jul 03, 2019 at 02:45:12PM -0700, Jeffrey Hugo wrote: >> Add basic support with a simple implementation that utilizes the generic >> read/write commands to allow device registers to be configured. > This looks good to me but I really don't know anyth

Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-11 Thread Jeffrey Hugo
On Fri, Jul 5, 2019 at 7:06 PM Mark Brown wrote: > > On Wed, Jul 03, 2019 at 02:45:12PM -0700, Jeffrey Hugo wrote: > > Add basic support with a simple implementation that utilizes the generic > > read/write commands to allow device registers to be configured. > > This looks good to me but I really

Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-05 Thread Mark Brown
On Wed, Jul 03, 2019 at 02:45:12PM -0700, Jeffrey Hugo wrote: > Add basic support with a simple implementation that utilizes the generic > read/write commands to allow device registers to be configured. This looks good to me but I really don't know anything about DSI, I'd appreciate some review fr

[PATCH 1/2] regmap: Add DSI bus support

2019-07-04 Thread Jeffrey Hugo
Add basic support with a simple implementation that utilizes the generic read/write commands to allow device registers to be configured. Signed-off-by: Jeffrey Hugo --- drivers/base/regmap/Kconfig | 6 +++- drivers/base/regmap/Makefile | 1 + drivers/base/regmap/regmap-dsi.c | 62