Re: [PATCH 1/2] mm: mmap: fix fput in error path v2

2020-11-18 Thread Andrew Morton
On Wed, 18 Nov 2020 11:57:44 +0100 Christian König wrote: > Am 06.11.20 um 23:48 schrieb Andrew Morton: > > On Fri, 6 Nov 2020 12:48:05 +0100 "Christian König" > > wrote: > > > >> Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." > >> adds a workaround for a bug in mmap_region. > >> > >

Re: [PATCH 1/2] mm: mmap: fix fput in error path v2

2020-11-18 Thread Christian König
Am 06.11.20 um 23:48 schrieb Andrew Morton: On Fri, 6 Nov 2020 12:48:05 +0100 "Christian König" wrote: Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." adds a workaround for a bug in mmap_region. As the comment states ->mmap() callback can change vma->vm_file and so we might call fpu

Re: [PATCH 1/2] mm: mmap: fix fput in error path v2

2020-11-06 Thread Andrew Morton
On Fri, 6 Nov 2020 12:48:05 +0100 "Christian König" wrote: > Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." > adds a workaround for a bug in mmap_region. > > As the comment states ->mmap() callback can change > vma->vm_file and so we might call fput() on the wrong file. > > Revert th

[PATCH 1/2] mm: mmap: fix fput in error path v2

2020-11-06 Thread Christian König
Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." adds a workaround for a bug in mmap_region. As the comment states ->mmap() callback can change vma->vm_file and so we might call fput() on the wrong file. Revert the workaround and proper fix this in mmap_region. v2: drop the extra if in dm

Re: [PATCH 1/2] mm: mmap: fix fput in error path v2

2020-11-04 Thread Christian König
If nobody comes up with an objections I'm going to merge that through drm-misc-next. Thanks, Christian. Am 12.10.20 um 10:52 schrieb Christian König: Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." adds a workaround for a bug in mmap_region. As the comment states ->mmap() callback can

Re: [PATCH 1/2] mm: mmap: fix fput in error path v2

2020-10-17 Thread Jason Gunthorpe
On Mon, Oct 12, 2020 at 10:52:02AM +0200, Christian König wrote: > Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." > adds a workaround for a bug in mmap_region. > > As the comment states ->mmap() callback can change > vma->vm_file and so we might call fput() on the wrong file. > > Revert

[PATCH 1/2] mm: mmap: fix fput in error path v2

2020-10-12 Thread Christian König
Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." adds a workaround for a bug in mmap_region. As the comment states ->mmap() callback can change vma->vm_file and so we might call fput() on the wrong file. Revert the workaround and proper fix this in mmap_region. v2: drop the extra if in dm