Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Kees Cook
On March 13, 2025 10:42:10 AM PDT, Aditya Garg wrote: >I already sent the 1st patch to DRM. I can rebase the test-printf bit to this >tree. Sounds good? Yeah, sounds good to me! Thanks :) -Kees -- Kees Cook

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
Hi > On 13 Mar 2025, at 11:10 PM, Kees Cook wrote: > > On Thu, Mar 13, 2025 at 11:48:32AM +0100, Petr Mladek wrote: >> So I am fine with this patch: >> >> Reviewed-by: Petr Mladek >> Tested-by: Petr Mladek >> >> >> Now, the question is how to get this patch into the mainline. >> >> Normal

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Kees Cook
On Thu, Mar 13, 2025 at 11:48:32AM +0100, Petr Mladek wrote: > So I am fine with this patch: > > Reviewed-by: Petr Mladek > Tested-by: Petr Mladek > > > Now, the question is how to get this patch into the mainline. > > Normally, it would make perfect sense to queue it via the DRM tree > becau

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 2:19 PM, Andy Shevchenko > wrote: > > On Thu, Mar 13, 2025 at 07:26:05AM +, Aditya Garg wrote: On 13 Mar 2025, at 12:58 AM, Andy Shevchenko wrote: >>> On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg wrote: > On 12 Mar 2025, at 9:05 PM, Sven Peter

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Andy Shevchenko
On Thu, Mar 13, 2025 at 11:06:54AM +, Aditya Garg wrote: > > On 13 Mar 2025, at 4:18 PM, Petr Mladek wrote: > > On Thu 2025-03-13 09:13:23, Aditya Garg wrote: > >>> On 13 Mar 2025, at 2:27 PM, Andy Shevchenko > >>> wrote: > >>> On Thu, Mar 13, 2025 at 08:53:28AM +, Aditya Garg wrote: > >

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Andy Shevchenko
On Thu, Mar 13, 2025 at 08:53:28AM +, Aditya Garg wrote: > > On 13 Mar 2025, at 2:19 PM, Andy Shevchenko > > wrote: > > On Thu, Mar 13, 2025 at 07:26:05AM +, Aditya Garg wrote: > On 13 Mar 2025, at 12:58 AM, Andy Shevchenko > wrote: > >>> On Wed, Mar 12, 2025 at 07:14:36PM +00

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 4:18 PM, Petr Mladek wrote: > > Adding Kees into Cc to resolve how to get this patch into the mainline. > > On Thu 2025-03-13 09:13:23, Aditya Garg wrote: >> >> >>> On 13 Mar 2025, at 2:27 PM, Andy Shevchenko >>> wrote: >>> >>> On Thu, Mar 13, 2025 at 08:53:28AM +000

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Petr Mladek
Adding Kees into Cc to resolve how to get this patch into the mainline. On Thu 2025-03-13 09:13:23, Aditya Garg wrote: > > > > On 13 Mar 2025, at 2:27 PM, Andy Shevchenko > > wrote: > > > > On Thu, Mar 13, 2025 at 08:53:28AM +, Aditya Garg wrote: > On 13 Mar 2025, at 2:19 PM, Andy S

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 2:27 PM, Andy Shevchenko > wrote: > > On Thu, Mar 13, 2025 at 08:53:28AM +, Aditya Garg wrote: On 13 Mar 2025, at 2:19 PM, Andy Shevchenko wrote: >>> On Thu, Mar 13, 2025 at 07:26:05AM +, Aditya Garg wrote: >> On 13 Mar 2025, at 12:58 AM, Andy Shev

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Andy Shevchenko
On Thu, Mar 13, 2025 at 07:26:05AM +, Aditya Garg wrote: > > On 13 Mar 2025, at 12:58 AM, Andy Shevchenko > > wrote: > > On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg wrote: > >>> On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: > >>> On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote:

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 12:58 AM, Andy Shevchenko > wrote: > > On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg wrote: >>> On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: >>> On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: > > ... > >>> I don't have a strong opinion either way: for SMC I

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Andy Shevchenko
On Wed, Mar 12, 2025 at 07:35:54PM +, Aditya Garg wrote: > > On 13 Mar 2025, at 12:58 AM, Andy Shevchenko > > wrote: > > On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg wrote: > On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: > >>> On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote:

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 13 Mar 2025, at 12:58 AM, Andy Shevchenko > wrote: > > On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg wrote: On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: >>> On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: > > ... > >>> I don't have a strong opinion either way: for SMC

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Andy Shevchenko
On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg wrote: > > On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: > > On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: ... > > I don't have a strong opinion either way: for SMC I just need to print > > FourCC keys for debugging / information in a fe

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: > > Hi, > > > On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: On 12 Mar 2025, at 5:29 PM, Thomas Zimmermann wrote: >>> >>> Hi >>> Am 12.03.25 um 12:49 schrieb Aditya Garg: >> On 12 Mar 2025, at 5:16 PM, Thomas Zimmerm

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Sven Peter
Hi, On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: >> On 12 Mar 2025, at 5:29 PM, Thomas Zimmermann wrote: >> >> Hi >> >>> Am 12.03.25 um 12:49 schrieb Aditya Garg: >>> > On 12 Mar 2025, at 5:16 PM, Thomas Zimmermann wrote: Hi > Am 12.03.25 um 10:05 schrieb Adi

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 12 Mar 2025, at 5:33 PM, Aditya Garg wrote: > >  > >> On 12 Mar 2025, at 5:29 PM, Thomas Zimmermann wrote: >> >> Hi >> Am 12.03.25 um 12:49 schrieb Aditya Garg: >>> > On 12 Mar 2025, at 5:16 PM, Thomas Zimmermann wrote: Hi > Am 12.03.25 um 10:05 schri

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 12 Mar 2025, at 5:29 PM, Thomas Zimmermann wrote: > > Hi > >> Am 12.03.25 um 12:49 schrieb Aditya Garg: >> On 12 Mar 2025, at 5:16 PM, Thomas Zimmermann wrote: >>> >>> Hi >>> Am 12.03.25 um 10:05 schrieb Aditya Garg: From: Hector Martin %p4cc is designed f

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Thomas Zimmermann
Hi Am 12.03.25 um 12:49 schrieb Aditya Garg: On 12 Mar 2025, at 5:16 PM, Thomas Zimmermann wrote: Hi Am 12.03.25 um 10:05 schrieb Aditya Garg: From: Hector Martin %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but it's useful to be able to print generic 4-character c

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 12 Mar 2025, at 5:16 PM, Thomas Zimmermann wrote: > > Hi > >> Am 12.03.25 um 10:05 schrieb Aditya Garg: >> From: Hector Martin >> >> %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but >> it's useful to be able to print generic 4-character codes formatted as >> an in

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Thomas Zimmermann
Hi Am 12.03.25 um 10:05 schrieb Aditya Garg: From: Hector Martin %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but it's useful to be able to print generic 4-character codes formatted as an integer. Extend it to add format specifiers for printing generic 32-bit FourCCs with

[PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
From: Hector Martin %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but it's useful to be able to print generic 4-character codes formatted as an integer. Extend it to add format specifiers for printing generic 32-bit FourCCs with various endian semantics: %p4ch Host byte or