[PATCH 1/2] drm: remove agp_init() bus callback

2013-11-03 Thread Daniel Vetter
On Sun, Nov 3, 2013 at 12:43 PM, David Herrmann wrote: >> Wrt patch 2 I don't see the point - better to just outright kill this >> callback and inline it like the agp_init one. > > 2/2 just does a rename. Where do you want to inline it? In > drm_pci_exit()? It calls drm_put_dev() which already do

[PATCH 1/2] drm: remove agp_init() bus callback

2013-11-03 Thread David Herrmann
Hi Daniel On Sun, Nov 3, 2013 at 12:36 PM, Daniel Vetter wrote: > On Sun, Nov 03, 2013 at 12:06:05PM +0100, David Herrmann wrote: >> Hi Dave >> >> This one can also go into 3.13. This and 2/2 provide the agp_init() >> cleanup that Daniel suggested for the drm_dev_*() patches. 2/2 is not >> requir

[PATCH 1/2] drm: remove agp_init() bus callback

2013-11-03 Thread Daniel Vetter
On Sun, Nov 03, 2013 at 12:06:05PM +0100, David Herrmann wrote: > Hi Dave > > This one can also go into 3.13. This and 2/2 provide the agp_init() > cleanup that Daniel suggested for the drm_dev_*() patches. 2/2 is not > required, but I thought it was a nice addition. I have a few more patches to

[PATCH 1/2] drm: remove agp_init() bus callback

2013-11-03 Thread David Herrmann
Hi Dave This one can also go into 3.13. This and 2/2 provide the agp_init() cleanup that Daniel suggested for the drm_dev_*() patches. 2/2 is not required, but I thought it was a nice addition. Thanks David On Sat, Oct 19, 2013 at 1:58 PM, David Herrmann wrote: > The PCI bus helper is the only

[PATCH 1/2] drm: remove agp_init() bus callback

2013-10-19 Thread David Herrmann
The PCI bus helper is the only user of it. Call it directly before device-registration to get rid of the callback. Note that all drm_agp_*() calls are locked with the drm-global-mutex so we need to explicitly lock it during initialization. It's not really clear why it's needed, but lets be safe.