Re: [PATCH 1/2] drm: refernce count event->completion

2017-02-09 Thread Jim Rees
Daniel Vetter wrote: Latest report just says that the revert isn't helping either. I suspect the report is a giantic conflagration of everything ever that kills various reporters boxes. I still believe that the patch here fixes the original bug, but there might be a lot more hiding. I

Re: [PATCH 1/2] drm: refernce count event->completion

2017-02-09 Thread Daniel Vetter
On Thu, Feb 09, 2017 at 04:39:29PM +0200, Jani Nikula wrote: > On Wed, 04 Jan 2017, Daniel Vetter wrote: > > On Wed, Dec 21, 2016 at 12:08:45PM +0100, Maarten Lankhorst wrote: > >> Op 21-12-16 om 11:36 schreef Chris Wilson: > >> > On Wed, Dec 21, 2016 at 11:23:30AM +0100, Daniel Vetter wrote: > >>

Re: [PATCH 1/2] drm: refernce count event->completion

2017-02-09 Thread Jani Nikula
On Wed, 04 Jan 2017, Daniel Vetter wrote: > On Wed, Dec 21, 2016 at 12:08:45PM +0100, Maarten Lankhorst wrote: >> Op 21-12-16 om 11:36 schreef Chris Wilson: >> > On Wed, Dec 21, 2016 at 11:23:30AM +0100, Daniel Vetter wrote: >> >> When writing the generic nonblocking commit code I assumed that >>

[PATCH 1/2] drm: refernce count event->completion

2017-01-04 Thread Daniel Vetter
On Wed, Dec 21, 2016 at 12:08:45PM +0100, Maarten Lankhorst wrote: > Op 21-12-16 om 11:36 schreef Chris Wilson: > > On Wed, Dec 21, 2016 at 11:23:30AM +0100, Daniel Vetter wrote: > >> When writing the generic nonblocking commit code I assumed that > >> through clever lifetime management I can assur

[PATCH 1/2] drm: refernce count event->completion

2016-12-21 Thread Daniel Vetter
On Wed, Dec 21, 2016 at 10:36:41AM +, Chris Wilson wrote: > On Wed, Dec 21, 2016 at 11:23:30AM +0100, Daniel Vetter wrote: > > When writing the generic nonblocking commit code I assumed that > > through clever lifetime management I can assure that the completion > > (stored in drm_crtc_commit)

[PATCH 1/2] drm: refernce count event->completion

2016-12-21 Thread Maarten Lankhorst
Op 21-12-16 om 11:36 schreef Chris Wilson: > On Wed, Dec 21, 2016 at 11:23:30AM +0100, Daniel Vetter wrote: >> When writing the generic nonblocking commit code I assumed that >> through clever lifetime management I can assure that the completion >> (stored in drm_crtc_commit) only gets freed after

[PATCH 1/2] drm: refernce count event->completion

2016-12-21 Thread Daniel Vetter
When writing the generic nonblocking commit code I assumed that through clever lifetime management I can assure that the completion (stored in drm_crtc_commit) only gets freed after it is completed. And that worked. I also wanted to make nonblocking helpers resilient against driver bugs, by having

[PATCH 1/2] drm: refernce count event->completion

2016-12-21 Thread Chris Wilson
On Wed, Dec 21, 2016 at 11:23:30AM +0100, Daniel Vetter wrote: > When writing the generic nonblocking commit code I assumed that > through clever lifetime management I can assure that the completion > (stored in drm_crtc_commit) only gets freed after it is completed. And > that worked. > > I also