Re: [PATCH 1/2] drm: fixup headers_check

2011-01-17 Thread Felipe Balbi
Hi, On Sun, Jan 16, 2011 at 09:42:37PM +1000, Dave Airlie wrote: > I'll push the attached I think this time. the point of headers_check is exactly to prevent indirect inclusion. This is even 1st topic o SubmitChecklist: " 1: If you use a facility then #include the file that defines/declares that

Re: [PATCH 1/2] drm: fixup headers_check

2011-01-17 Thread Felipe Balbi
On Sun, Jan 16, 2011 at 01:16:16PM +0200, Felipe Balbi wrote: > I truly have those types in use. I meant you :-p -- balbi ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm: fixup headers_check

2011-01-17 Thread Felipe Balbi
On Sun, Jan 16, 2011 at 11:07:32AM +, Chris Wilson wrote: > On Sun, 16 Jan 2011 12:46:22 +0200, Felipe Balbi wrote: > > Drop the following headers_check errors: > > /linux-2.6/usr/include/drm/drm_mode.h:85: found > > __[us]{8,16,32,64} type without #include > > /linux-2.6/usr/include/drm/i915

Re: [PATCH 1/2] drm: fixup headers_check

2011-01-17 Thread Felipe Balbi
Hi, On Sun, Jan 16, 2011 at 12:46:22PM +0200, Felipe Balbi wrote: > Drop the following headers_check errors: > /linux-2.6/usr/include/drm/drm_mode.h:85: found > __[us]{8,16,32,64} type without #include > /linux-2.6/usr/include/drm/i915_drm.h:120: found > __[us]{8,16,32,64} type without #include

[PATCH 1/2] drm: fixup headers_check

2011-01-17 Thread Felipe Balbi
Drop the following headers_check errors: /linux-2.6/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include /linux-2.6/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include /linux-2.6/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type witho

[PATCH 1/2] drm: fixup headers_check

2011-01-16 Thread Dave Airlie
I'll push the attached I think this time. Dave. -- next part -- A non-text attachment was scrubbed... Name: 0001-drm-add-comments-to-stop-pointless-patches.patch Type: text/x-patch Size: 2378 bytes Desc: not available URL:

[PATCH 1/2] drm: fixup headers_check

2011-01-16 Thread Felipe Balbi
Hi, On Sun, Jan 16, 2011 at 09:42:37PM +1000, Dave Airlie wrote: > I'll push the attached I think this time. the point of headers_check is exactly to prevent indirect inclusion. This is even 1st topic o SubmitChecklist: " 1: If you use a facility then #include the file that defines/declares that

[PATCH 1/2] drm: fixup headers_check

2011-01-16 Thread Felipe Balbi
On Sun, Jan 16, 2011 at 01:16:16PM +0200, Felipe Balbi wrote: > I truly have those types in use. I meant you :-p -- balbi

[PATCH 1/2] drm: fixup headers_check

2011-01-16 Thread Felipe Balbi
On Sun, Jan 16, 2011 at 11:07:32AM +, Chris Wilson wrote: > On Sun, 16 Jan 2011 12:46:22 +0200, Felipe Balbi wrote: > > Drop the following headers_check errors: > > /linux-2.6/usr/include/drm/drm_mode.h:85: found > > __[us]{8,16,32,64} type without #include > > /linux-2.6/usr/include/drm/i915

[PATCH 1/2] drm: fixup headers_check

2011-01-16 Thread Felipe Balbi
Hi, On Sun, Jan 16, 2011 at 12:46:22PM +0200, Felipe Balbi wrote: > Drop the following headers_check errors: > /linux-2.6/usr/include/drm/drm_mode.h:85: found > __[us]{8,16,32,64} type without #include > /linux-2.6/usr/include/drm/i915_drm.h:120: found > __[us]{8,16,32,64} type without #include

[PATCH 1/2] drm: fixup headers_check

2011-01-16 Thread Felipe Balbi
Drop the following headers_check errors: /linux-2.6/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include /linux-2.6/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include /linux-2.6/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type witho

[PATCH 1/2] drm: fixup headers_check

2011-01-16 Thread Chris Wilson
On Sun, 16 Jan 2011 12:46:22 +0200, Felipe Balbi wrote: > Drop the following headers_check errors: > /linux-2.6/usr/include/drm/drm_mode.h:85: found > __[us]{8,16,32,64} type without #include > /linux-2.6/usr/include/drm/i915_drm.h:120: found > __[us]{8,16,32,64} type without #include > /linux-2

Re: [PATCH 1/2] drm: fixup headers_check

2011-01-16 Thread Dave Airlie
I'll push the attached I think this time. Dave. From 1222ad4188aa2a6046da931487543507a59b7fac Mon Sep 17 00:00:00 2001 From: Dave Airlie Date: Sun, 16 Jan 2011 21:35:10 +1000 Subject: [PATCH] drm: add comments to stop pointless patches. How about you fix the headers script to be recursive? Sign

Re: [PATCH 1/2] drm: fixup headers_check

2011-01-16 Thread Chris Wilson
On Sun, 16 Jan 2011 12:46:22 +0200, Felipe Balbi wrote: > Drop the following headers_check errors: > /linux-2.6/usr/include/drm/drm_mode.h:85: found > __[us]{8,16,32,64} type without #include > /linux-2.6/usr/include/drm/i915_drm.h:120: found > __[us]{8,16,32,64} type without #include > /linux-2