Re: [PATCH 1/2] drm: Mark up accesses of vblank->enabled outside of its spinlock

2017-03-17 Thread Ville Syrjälä
On Fri, Mar 17, 2017 at 10:19:51AM +, Chris Wilson wrote: > On Fri, Mar 17, 2017 at 11:47:51AM +0200, Ville Syrjälä wrote: > > On Thu, Mar 16, 2017 at 11:47:48PM +, Chris Wilson wrote: > > > @@ -360,7 +358,7 @@ static void vblank_disable_fn(unsigned long arg) > > > unsigned long irqflags;

Re: [PATCH 1/2] drm: Mark up accesses of vblank->enabled outside of its spinlock

2017-03-17 Thread Chris Wilson
On Fri, Mar 17, 2017 at 11:47:51AM +0200, Ville Syrjälä wrote: > On Thu, Mar 16, 2017 at 11:47:48PM +, Chris Wilson wrote: > > @@ -360,7 +358,7 @@ static void vblank_disable_fn(unsigned long arg) > > unsigned long irqflags; > > > > spin_lock_irqsave(&dev->vbl_lock, irqflags); > > -

Re: [PATCH 1/2] drm: Mark up accesses of vblank->enabled outside of its spinlock

2017-03-17 Thread Ville Syrjälä
On Thu, Mar 16, 2017 at 11:47:48PM +, Chris Wilson wrote: > Order the update to vblank->enabled after the timestamp is primed so > that a concurrent unlocked reader will only see the vblank->enabled with > the current timestamp. > > Signed-off-by: Chris Wilson > Cc: Ville Syrjälä > Cc: Danie

[PATCH 1/2] drm: Mark up accesses of vblank->enabled outside of its spinlock

2017-03-16 Thread Chris Wilson
Order the update to vblank->enabled after the timestamp is primed so that a concurrent unlocked reader will only see the vblank->enabled with the current timestamp. Signed-off-by: Chris Wilson Cc: Ville Syrjälä Cc: Daniel Vetter --- drivers/gpu/drm/drm_irq.c | 30 ++