Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-05-04 Thread Jose Abreu
Hi Daniel, On 03-05-2017 16:00, Daniel Vetter wrote: > On Wed, May 03, 2017 at 03:16:13PM +0100, Jose Abreu wrote: >> Hi Daniel, >> >> >> On 03-05-2017 07:19, Daniel Vetter wrote: >>> On Tue, May 2, 2017 at 11:29 AM, Jose Abreu wrote: On 02-05-2017 09:48, Daniel Vetter wrote: > On Wed,

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-05-04 Thread Jose Abreu
Hi Daniel, On 03-05-2017 07:19, Daniel Vetter wrote: > On Tue, May 2, 2017 at 11:29 AM, Jose Abreu wrote: >> On 02-05-2017 09:48, Daniel Vetter wrote: >>> On Wed, Apr 26, 2017 at 11:48:34AM +0100, Jose Abreu wrote: Some crtc's may have restrictions in the mode they can display. In this

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-05-04 Thread Jose Abreu
Hi Daniel, On 04-05-2017 11:21, Jose Abreu wrote: > Hi Daniel, > > > On 03-05-2017 16:00, Daniel Vetter wrote: >> On Wed, May 03, 2017 at 03:16:13PM +0100, Jose Abreu wrote: >>> Hi Daniel, >>> >>> >>> On 03-05-2017 07:19, Daniel Vetter wrote: On Tue, May 2, 2017 at 11:29 AM, Jose Abreu >>>

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-05-04 Thread Ville Syrjälä
On Thu, May 04, 2017 at 02:49:31PM +0200, Daniel Vetter wrote: > On Wed, May 3, 2017 at 5:21 PM, Ville Syrjälä > wrote: > > We don't actually want the codepaths to match exactly. In i915 > > we allow the user to exceed some of the display/dongle limits > > because those things often tell us that s

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-05-04 Thread Daniel Vetter
On Wed, May 3, 2017 at 5:21 PM, Ville Syrjälä wrote: > We don't actually want the codepaths to match exactly. In i915 > we allow the user to exceed some of the display/dongle limits > because those things often tell us that something shouldn't work > when in fact it does. And some users are quick

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-05-04 Thread Daniel Vetter
On Thu, May 4, 2017 at 1:55 PM, Jose Abreu wrote: > On 04-05-2017 11:21, Jose Abreu wrote: >> Hi Daniel, >> >> >> On 03-05-2017 16:00, Daniel Vetter wrote: >>> On Wed, May 03, 2017 at 03:16:13PM +0100, Jose Abreu wrote: Hi Daniel, On 03-05-2017 07:19, Daniel Vetter wrote: >

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-05-03 Thread Ville Syrjälä
On Wed, May 03, 2017 at 05:00:31PM +0200, Daniel Vetter wrote: > On Wed, May 03, 2017 at 03:16:13PM +0100, Jose Abreu wrote: > > Hi Daniel, > > > > > > On 03-05-2017 07:19, Daniel Vetter wrote: > > > On Tue, May 2, 2017 at 11:29 AM, Jose Abreu > > > wrote: > > >> On 02-05-2017 09:48, Daniel Vet

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-05-03 Thread Daniel Vetter
On Wed, May 03, 2017 at 03:16:13PM +0100, Jose Abreu wrote: > Hi Daniel, > > > On 03-05-2017 07:19, Daniel Vetter wrote: > > On Tue, May 2, 2017 at 11:29 AM, Jose Abreu wrote: > >> On 02-05-2017 09:48, Daniel Vetter wrote: > >>> On Wed, Apr 26, 2017 at 11:48:34AM +0100, Jose Abreu wrote: >

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-05-02 Thread Daniel Vetter
On Tue, May 2, 2017 at 11:29 AM, Jose Abreu wrote: > On 02-05-2017 09:48, Daniel Vetter wrote: >> On Wed, Apr 26, 2017 at 11:48:34AM +0100, Jose Abreu wrote: >>> Some crtc's may have restrictions in the mode they can display. In >>> this patch a new callback (crtc->mode_valid()) is introduced that

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-05-02 Thread Daniel Vetter
On Tue, May 2, 2017 at 11:29 AM, Jose Abreu wrote: > On 02-05-2017 09:48, Daniel Vetter wrote: >> On Wed, Apr 26, 2017 at 11:48:34AM +0100, Jose Abreu wrote: >>> Some crtc's may have restrictions in the mode they can display. In >>> this patch a new callback (crtc->mode_valid()) is introduced that

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-05-02 Thread Jose Abreu
Hi Daniel, On 02-05-2017 09:48, Daniel Vetter wrote: > On Wed, Apr 26, 2017 at 11:48:34AM +0100, Jose Abreu wrote: >> Some crtc's may have restrictions in the mode they can display. In >> this patch a new callback (crtc->mode_valid()) is introduced that >> is called at the same stage of connector

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-05-02 Thread Daniel Vetter
On Wed, Apr 26, 2017 at 11:48:34AM +0100, Jose Abreu wrote: > Some crtc's may have restrictions in the mode they can display. In > this patch a new callback (crtc->mode_valid()) is introduced that > is called at the same stage of connector->mode_valid() callback. > > This shall be implemented if t

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-04-28 Thread Jose Abreu
Hi Ville, Thanks for the review! My comments inline. On 28-04-2017 12:41, Ville Syrjälä wrote: > On Wed, Apr 26, 2017 at 11:48:34AM +0100, Jose Abreu wrote: >> Some crtc's may have restrictions in the mode they can display. In >> this patch a new callback (crtc->mode_valid()) is introduced that

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-04-28 Thread Ville Syrjälä
On Fri, Apr 28, 2017 at 01:30:16PM +0100, Jose Abreu wrote: > Hi Ville, > > > Thanks for the review! My comments inline. > > > On 28-04-2017 12:41, Ville Syrjälä wrote: > > On Wed, Apr 26, 2017 at 11:48:34AM +0100, Jose Abreu wrote: > >> Some crtc's may have restrictions in the mode they can di

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-04-28 Thread Ville Syrjälä
On Wed, Apr 26, 2017 at 11:48:34AM +0100, Jose Abreu wrote: > Some crtc's may have restrictions in the mode they can display. In > this patch a new callback (crtc->mode_valid()) is introduced that > is called at the same stage of connector->mode_valid() callback. > > This shall be implemented if t

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-04-27 Thread Jose Abreu
Hi Andrzej, Thanks for your answer! On 27-04-2017 11:05, Andrzej Hajda wrote: > Hi Jose, > > On 26.04.2017 12:48, Jose Abreu wrote: >> Some crtc's may have restrictions in the mode they can display. In >> this patch a new callback (crtc->mode_valid()) is introduced that >> is called at the same

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-04-27 Thread Andrzej Hajda
Hi Jose, On 26.04.2017 12:48, Jose Abreu wrote: > Some crtc's may have restrictions in the mode they can display. In > this patch a new callback (crtc->mode_valid()) is introduced that > is called at the same stage of connector->mode_valid() callback. > > This shall be implemented if the crtc has

[PATCH 1/2] drm: Introduce crtc->mode_valid() callback

2017-04-26 Thread Jose Abreu
Some crtc's may have restrictions in the mode they can display. In this patch a new callback (crtc->mode_valid()) is introduced that is called at the same stage of connector->mode_valid() callback. This shall be implemented if the crtc has some sort of restriction so that we don't probe modes that