Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-14 Thread Rob Clark
On Fri, May 14, 2021 at 12:54 AM Pekka Paalanen wrote: > > On Wed, 12 May 2021 07:57:26 -0700 > Rob Clark wrote: > > > On Wed, May 12, 2021 at 1:23 AM Pekka Paalanen wrote: > > > > > > On Tue, 11 May 2021 18:44:17 +0200 > > > Daniel Vetter wrote: > > > > > > > On Mon, May 10, 2021 at 12:06:05PM

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-14 Thread Pekka Paalanen
On Wed, 12 May 2021 07:57:26 -0700 Rob Clark wrote: > On Wed, May 12, 2021 at 1:23 AM Pekka Paalanen wrote: > > > > On Tue, 11 May 2021 18:44:17 +0200 > > Daniel Vetter wrote: > > > > > On Mon, May 10, 2021 at 12:06:05PM -0700, Rob Clark wrote: > > > > On Mon, May 10, 2021 at 10:44 AM Danie

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-12 Thread Rob Clark
On Wed, May 12, 2021 at 1:23 AM Pekka Paalanen wrote: > > On Tue, 11 May 2021 18:44:17 +0200 > Daniel Vetter wrote: > > > On Mon, May 10, 2021 at 12:06:05PM -0700, Rob Clark wrote: > > > On Mon, May 10, 2021 at 10:44 AM Daniel Vetter wrote: > > > > > > > > On Mon, May 10, 2021 at 6:51 PM Rob Cla

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-12 Thread Daniel Vetter
On Wed, May 12, 2021 at 11:46 AM Pekka Paalanen wrote: > > On Wed, 12 May 2021 10:44:29 +0200 > Daniel Vetter wrote: > > > On Wed, May 12, 2021 at 11:23:30AM +0300, Pekka Paalanen wrote: > > > On Tue, 11 May 2021 18:44:17 +0200 > > > Daniel Vetter wrote: > > > > > > > On Mon, May 10, 2021 at 12:

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-12 Thread Pekka Paalanen
On Wed, 12 May 2021 10:44:29 +0200 Daniel Vetter wrote: > On Wed, May 12, 2021 at 11:23:30AM +0300, Pekka Paalanen wrote: > > On Tue, 11 May 2021 18:44:17 +0200 > > Daniel Vetter wrote: > > > > > On Mon, May 10, 2021 at 12:06:05PM -0700, Rob Clark wrote: > > > > On Mon, May 10, 2021 at 10:4

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-12 Thread Daniel Vetter
On Wed, May 12, 2021 at 11:23:30AM +0300, Pekka Paalanen wrote: > On Tue, 11 May 2021 18:44:17 +0200 > Daniel Vetter wrote: > > > On Mon, May 10, 2021 at 12:06:05PM -0700, Rob Clark wrote: > > > On Mon, May 10, 2021 at 10:44 AM Daniel Vetter wrote: > > > > > > > > On Mon, May 10, 2021 at 6:51

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-12 Thread Pekka Paalanen
On Tue, 11 May 2021 18:44:17 +0200 Daniel Vetter wrote: > On Mon, May 10, 2021 at 12:06:05PM -0700, Rob Clark wrote: > > On Mon, May 10, 2021 at 10:44 AM Daniel Vetter wrote: > > > > > > On Mon, May 10, 2021 at 6:51 PM Rob Clark wrote: > > > > > > > > On Mon, May 10, 2021 at 9:14 AM Daniel

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-11 Thread Daniel Vetter
On Tue, May 11, 2021 at 10:42:58AM -0700, Rob Clark wrote: > On Tue, May 11, 2021 at 10:21 AM Daniel Vetter wrote: > > > > On Tue, May 11, 2021 at 10:19:57AM -0700, Rob Clark wrote: > > > On Tue, May 11, 2021 at 9:44 AM Daniel Vetter wrote: > > > > > > > > On Mon, May 10, 2021 at 12:06:05PM -0700

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-11 Thread Rob Clark
On Tue, May 11, 2021 at 10:21 AM Daniel Vetter wrote: > > On Tue, May 11, 2021 at 10:19:57AM -0700, Rob Clark wrote: > > On Tue, May 11, 2021 at 9:44 AM Daniel Vetter wrote: > > > > > > On Mon, May 10, 2021 at 12:06:05PM -0700, Rob Clark wrote: > > > > On Mon, May 10, 2021 at 10:44 AM Daniel Vett

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-11 Thread Daniel Vetter
On Tue, May 11, 2021 at 10:19:57AM -0700, Rob Clark wrote: > On Tue, May 11, 2021 at 9:44 AM Daniel Vetter wrote: > > > > On Mon, May 10, 2021 at 12:06:05PM -0700, Rob Clark wrote: > > > On Mon, May 10, 2021 at 10:44 AM Daniel Vetter wrote: > > > > > > > > On Mon, May 10, 2021 at 6:51 PM Rob Clar

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-11 Thread Rob Clark
On Tue, May 11, 2021 at 9:44 AM Daniel Vetter wrote: > > On Mon, May 10, 2021 at 12:06:05PM -0700, Rob Clark wrote: > > On Mon, May 10, 2021 at 10:44 AM Daniel Vetter wrote: > > > > > > On Mon, May 10, 2021 at 6:51 PM Rob Clark wrote: > > > > > > > > On Mon, May 10, 2021 at 9:14 AM Daniel Vetter

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-11 Thread Daniel Vetter
On Mon, May 10, 2021 at 12:06:05PM -0700, Rob Clark wrote: > On Mon, May 10, 2021 at 10:44 AM Daniel Vetter wrote: > > > > On Mon, May 10, 2021 at 6:51 PM Rob Clark wrote: > > > > > > On Mon, May 10, 2021 at 9:14 AM Daniel Vetter wrote: > > > > > > > > On Sat, May 08, 2021 at 12:56:38PM -0700, R

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-10 Thread Rob Clark
On Mon, May 10, 2021 at 10:44 AM Daniel Vetter wrote: > > On Mon, May 10, 2021 at 6:51 PM Rob Clark wrote: > > > > On Mon, May 10, 2021 at 9:14 AM Daniel Vetter wrote: > > > > > > On Sat, May 08, 2021 at 12:56:38PM -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > drm_atomic_helpe

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-10 Thread Daniel Vetter
On Mon, May 10, 2021 at 6:51 PM Rob Clark wrote: > > On Mon, May 10, 2021 at 9:14 AM Daniel Vetter wrote: > > > > On Sat, May 08, 2021 at 12:56:38PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > drm_atomic_helper_dirtyfb() will end up stalling for vblank on "video > > > mode" type di

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-10 Thread Rob Clark
On Mon, May 10, 2021 at 9:14 AM Daniel Vetter wrote: > > On Sat, May 08, 2021 at 12:56:38PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > drm_atomic_helper_dirtyfb() will end up stalling for vblank on "video > > mode" type displays, which is pointless and unnecessary. Add an > > optional h

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-10 Thread Daniel Vetter
On Mon, May 10, 2021 at 06:14:20PM +0200, Daniel Vetter wrote: > On Sat, May 08, 2021 at 12:56:38PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > drm_atomic_helper_dirtyfb() will end up stalling for vblank on "video > > mode" type displays, which is pointless and unnecessary. Add an > > op

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-10 Thread Daniel Vetter
On Sat, May 08, 2021 at 12:56:38PM -0700, Rob Clark wrote: > From: Rob Clark > > drm_atomic_helper_dirtyfb() will end up stalling for vblank on "video > mode" type displays, which is pointless and unnecessary. Add an > optional helper vfunc to determine if a plane is attached to a CRTC > that ac

[PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-08 Thread Rob Clark
From: Rob Clark drm_atomic_helper_dirtyfb() will end up stalling for vblank on "video mode" type displays, which is pointless and unnecessary. Add an optional helper vfunc to determine if a plane is attached to a CRTC that actually needs dirtyfb, and skip over them. Signed-off-by: Rob Clark --