[PATCH 1/2] drm: Create and use drm_err

2011-04-19 Thread Dave Airlie
On Mon, 2011-04-18 at 15:56 -0700, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/17/2011 08:35 PM, Joe Perches wrote: > > Reduce drm text size ~1% by using drm_err and > > printf extension %pV to emit error messages. > > > > Remove unused macro DRM_MEM_ERROR. > >

Re: [PATCH 1/2] drm: Create and use drm_err

2011-04-18 Thread Joe Perches
On Mon, 2011-04-18 at 15:56 -0700, Ian Romanick wrote: > I believe that DRM_NAME is a define, and drm_stub.c is in common code. > As a result, won't this change cause something different to get logged? Nope. DRM_NAME is #defined only once. include/drm/drm.h:#define DRM_NAME "drm" The on

[PATCH 1/2] drm: Create and use drm_err

2011-04-18 Thread Joe Perches
On Mon, 2011-04-18 at 15:56 -0700, Ian Romanick wrote: > I believe that DRM_NAME is a define, and drm_stub.c is in common code. > As a result, won't this change cause something different to get logged? Nope. DRM_NAME is #defined only once. include/drm/drm.h:#define DRM_NAME "drm" The on

Re: [PATCH 1/2] drm: Create and use drm_err

2011-04-18 Thread Dave Airlie
On Mon, 2011-04-18 at 15:56 -0700, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/17/2011 08:35 PM, Joe Perches wrote: > > Reduce drm text size ~1% by using drm_err and > > printf extension %pV to emit error messages. > > > > Remove unused macro DRM_MEM_ERROR. > >

Re: [PATCH 1/2] drm: Create and use drm_err

2011-04-18 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/17/2011 08:35 PM, Joe Perches wrote: > Reduce drm text size ~1% by using drm_err and > printf extension %pV to emit error messages. > > Remove unused macro DRM_MEM_ERROR. > > $ size drivers/gpu/drm/built-in.o* >text data bss

[PATCH 1/2] drm: Create and use drm_err

2011-04-18 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/17/2011 08:35 PM, Joe Perches wrote: > Reduce drm text size ~1% by using drm_err and > printf extension %pV to emit error messages. > > Remove unused macro DRM_MEM_ERROR. > > $ size drivers/gpu/drm/built-in.o* >text data bss

[PATCH 1/2] drm: Create and use drm_err

2011-04-17 Thread Joe Perches
Reduce drm text size ~1% by using drm_err and printf extension %pV to emit error messages. Remove unused macro DRM_MEM_ERROR. $ size drivers/gpu/drm/built-in.o* textdata bss dec hex filename 3611599663 256 371078 5a986 drivers/gpu/drm/built-in.o.new 3654169663

[PATCH 1/2] drm: Create and use drm_err

2011-04-17 Thread Joe Perches
Reduce drm text size ~1% by using drm_err and printf extension %pV to emit error messages. Remove unused macro DRM_MEM_ERROR. $ size drivers/gpu/drm/built-in.o* textdata bss dec hex filename 3611599663 256 371078 5a986 drivers/gpu/drm/built-in.o.new 3654169663