Re: [PATCH 1/2] drm/vram: store dumb bo dimensions.

2019-07-10 Thread Daniel Vetter
On Mon, Jul 08, 2019 at 04:39:45PM +0300, Pekka Paalanen wrote: > On Wed, 26 Jun 2019 18:27:54 +0200 > Daniel Vetter wrote: > > > On Wed, Jun 26, 2019 at 04:40:13PM +0200, Sam Ravnborg wrote: > > > Hi Gerd. > > > > > > On Wed, Jun 26, 2019 at 08:55:50AM +0200, Gerd Hoffmann wrote: > > > > Stor

Re: [PATCH 1/2] drm/vram: store dumb bo dimensions.

2019-07-08 Thread Pekka Paalanen
On Wed, 26 Jun 2019 18:27:54 +0200 Daniel Vetter wrote: > On Wed, Jun 26, 2019 at 04:40:13PM +0200, Sam Ravnborg wrote: > > Hi Gerd. > > > > On Wed, Jun 26, 2019 at 08:55:50AM +0200, Gerd Hoffmann wrote: > > > Store width and height of the bo. Needed in case userspace > > > sets up a framebuf

Re: [PATCH 1/2] drm/vram: store dumb bo dimensions.

2019-06-27 Thread Gerd Hoffmann
Hi, > For the Gnome issue, a fix would be to program the display HW's line > pitch to the correct value. Yes, and drm_framebuffer actually has the pitches, so no need for this patch indeed. cheers, Gerd

Re: [PATCH 1/2] drm/vram: store dumb bo dimensions.

2019-06-27 Thread Thomas Zimmermann
Hi Am 26.06.19 um 08:55 schrieb Gerd Hoffmann: > Store width and height of the bo. Needed in case userspace > sets up a framebuffer with fb->width != bo->width.. This seems like bug. I'd rather return an error to userspace if the BO is incompatible. For the Gnome issue, a fix would be to progra

Re: [PATCH 1/2] drm/vram: store dumb bo dimensions.

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 04:40:13PM +0200, Sam Ravnborg wrote: > Hi Gerd. > > On Wed, Jun 26, 2019 at 08:55:50AM +0200, Gerd Hoffmann wrote: > > Store width and height of the bo. Needed in case userspace > > sets up a framebuffer with fb->width != bo->width.. > > > > Signed-off-by: Gerd Hoffmann

Re: [PATCH 1/2] drm/vram: store dumb bo dimensions.

2019-06-26 Thread Sam Ravnborg
Hi Gerd. On Wed, Jun 26, 2019 at 08:55:50AM +0200, Gerd Hoffmann wrote: > Store width and height of the bo. Needed in case userspace > sets up a framebuffer with fb->width != bo->width.. > > Signed-off-by: Gerd Hoffmann > --- > include/drm/drm_gem_vram_helper.h | 1 + > drivers/gpu/drm/drm

[PATCH 1/2] drm/vram: store dumb bo dimensions.

2019-06-25 Thread Gerd Hoffmann
Store width and height of the bo. Needed in case userspace sets up a framebuffer with fb->width != bo->width.. Signed-off-by: Gerd Hoffmann --- include/drm/drm_gem_vram_helper.h | 1 + drivers/gpu/drm/drm_gem_vram_helper.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/include/drm/d