[PATCH 1/2] drm/udl: fix a NULL pointer reference in udl_gem_free_object().

2016-09-01 Thread Daniel Vetter
On Thu, Sep 1, 2016 at 3:22 AM, Haixia Shi wrote: > Daniel > > Thanks! I agree the PATCH 1/2 needs some more work. > > What do you think about the PATCH 2/2 (suspend/resume) -- would it > make sense to review it as a single standalone patch? Sure, but I have no clue about usb or udl-specific issu

[PATCH 1/2] drm/udl: fix a NULL pointer reference in udl_gem_free_object().

2016-08-31 Thread Daniel Vetter
On Wed, Aug 31, 2016 at 11:05 PM, Daniel Vetter wrote: > On Wed, Aug 31, 2016 at 10:45 PM, Haixia Shi wrote: >> For details see https://bugs.chromium.org/p/chromium/issues/detail?id=468050 >> >> So drm_mode_config_cleanup() is called from udl_driver_unload() in >> which we found there's still a f

[PATCH 1/2] drm/udl: fix a NULL pointer reference in udl_gem_free_object().

2016-08-31 Thread Daniel Vetter
On Wed, Aug 31, 2016 at 10:45 PM, Haixia Shi wrote: > For details see https://bugs.chromium.org/p/chromium/issues/detail?id=468050 > > So drm_mode_config_cleanup() is called from udl_driver_unload() in > which we found there's still a framebuffer left, hence the WARN in > drm_crtc.c:5495. This als

[PATCH 1/2] drm/udl: fix a NULL pointer reference in udl_gem_free_object().

2016-08-31 Thread Haixia Shi
Daniel Thanks! I agree the PATCH 1/2 needs some more work. What do you think about the PATCH 2/2 (suspend/resume) -- would it make sense to review it as a single standalone patch? Regards, Haixia On Wed, Aug 31, 2016 at 2:17 PM, Daniel Vetter wrote: > On Wed, Aug 31, 2016 at 11:05 PM, Daniel V

[PATCH 1/2] drm/udl: fix a NULL pointer reference in udl_gem_free_object().

2016-08-31 Thread Haixia Shi
For details see https://bugs.chromium.org/p/chromium/issues/detail?id=468050 So drm_mode_config_cleanup() is called from udl_driver_unload() in which we found there's still a framebuffer left, hence the WARN in drm_crtc.c:5495. This also forcefully releases all the buffers. A bit later the actual

[PATCH 1/2] drm/udl: fix a NULL pointer reference in udl_gem_free_object().

2016-08-31 Thread Daniel Vetter
On Tue, Aug 30, 2016 at 02:50:20PM -0700, Haixia Shi wrote: > Previously this function had a NULL pointer check for gem->map_list.map, but > that line was refactored after commit > 0de23977cfeb5b357ec884ba15417ae118ff9e9bb > ("drm/gem: convert to new unified vma manager"). > > After the refactor

[PATCH 1/2] drm/udl: fix a NULL pointer reference in udl_gem_free_object().

2016-08-30 Thread Haixia Shi
Previously this function had a NULL pointer check for gem->map_list.map, but that line was refactored after commit 0de23977cfeb5b357ec884ba15417ae118ff9e9bb ("drm/gem: convert to new unified vma manager"). After the refactor it is still necessasry to check that the vma manager is not NULL because