Re: [PATCH 1/2] drm/ttm: fix locking in vmap/vunmap TTM GEM helpers

2022-07-19 Thread Christian König
Am 19.07.22 um 09:19 schrieb Thomas Zimmermann: Hi Am 15.07.22 um 17:58 schrieb Christian König: Am 15.07.22 um 17:36 schrieb Thomas Zimmermann: Hi Am 15.07.22 um 13:15 schrieb Christian König: I've stumbled over this while reviewing patches for DMA-buf and it looks like we completely messe

Re: [PATCH 1/2] drm/ttm: fix locking in vmap/vunmap TTM GEM helpers

2022-07-19 Thread Thomas Zimmermann
Hi Am 15.07.22 um 17:58 schrieb Christian König: Am 15.07.22 um 17:36 schrieb Thomas Zimmermann: Hi Am 15.07.22 um 13:15 schrieb Christian König: I've stumbled over this while reviewing patches for DMA-buf and it looks like we completely messed the locking up here. In general most TTM functi

Re: [PATCH 1/2] drm/ttm: fix locking in vmap/vunmap TTM GEM helpers

2022-07-17 Thread Dmitry Osipenko
On 7/15/22 18:58, Christian König wrote: > Am 15.07.22 um 17:36 schrieb Thomas Zimmermann: >> Hi >> >> Am 15.07.22 um 13:15 schrieb Christian König: >>> I've stumbled over this while reviewing patches for DMA-buf and it looks >>> like we completely messed the locking up here. >>> >>> In general mos

Re: [PATCH 1/2] drm/ttm: fix locking in vmap/vunmap TTM GEM helpers

2022-07-16 Thread Thomas Zimmermann
Hi Am 15.07.22 um 13:15 schrieb Christian König: I've stumbled over this while reviewing patches for DMA-buf and it looks like we completely messed the locking up here. In general most TTM function should only be called while holding the appropriate BO resv lock. Without this we could break the

Re: [PATCH 1/2] drm/ttm: fix locking in vmap/vunmap TTM GEM helpers

2022-07-16 Thread Christian König
Am 15.07.22 um 17:36 schrieb Thomas Zimmermann: Hi Am 15.07.22 um 13:15 schrieb Christian König: I've stumbled over this while reviewing patches for DMA-buf and it looks like we completely messed the locking up here. In general most TTM function should only be called while holding the appropri

Re: [PATCH 1/2] drm/ttm: fix locking in vmap/vunmap TTM GEM helpers

2022-07-16 Thread Dmitry Osipenko
On 7/15/22 14:33, Christian König wrote: > Am 15.07.22 um 13:31 schrieb Dmitry Osipenko: >> On 7/15/22 14:15, Christian König wrote: >>> I've stumbled over this while reviewing patches for DMA-buf and it looks >>> like we completely messed the locking up here. >>> >>> In general most TTM function s

Re: [PATCH 1/2] drm/ttm: fix locking in vmap/vunmap TTM GEM helpers

2022-07-15 Thread Christian König
Am 15.07.22 um 13:31 schrieb Dmitry Osipenko: On 7/15/22 14:15, Christian König wrote: I've stumbled over this while reviewing patches for DMA-buf and it looks like we completely messed the locking up here. In general most TTM function should only be called while holding the appropriate BO resv

Re: [PATCH 1/2] drm/ttm: fix locking in vmap/vunmap TTM GEM helpers

2022-07-15 Thread Dmitry Osipenko
On 7/15/22 14:15, Christian König wrote: > I've stumbled over this while reviewing patches for DMA-buf and it looks > like we completely messed the locking up here. > > In general most TTM function should only be called while holding the > appropriate BO resv lock. Without this we could break the

[PATCH 1/2] drm/ttm: fix locking in vmap/vunmap TTM GEM helpers

2022-07-15 Thread Christian König
I've stumbled over this while reviewing patches for DMA-buf and it looks like we completely messed the locking up here. In general most TTM function should only be called while holding the appropriate BO resv lock. Without this we could break the internal buffer object state here. Only compile te