Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-18 Thread Thomas Zimmermann
Hi Am 18.05.20 um 16:40 schrieb Daniel Vetter: > On Mon, May 18, 2020 at 12:11:32PM +0200, Gerd Hoffmann wrote: >> On Mon, May 18, 2020 at 10:50:15AM +0200, Thomas Zimmermann wrote: >>> Hi Gerd >>> >>> Am 18.05.20 um 10:23 schrieb Gerd Hoffmann: >> $ git grep drm_gem_shmem_mmap >> >> W

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-18 Thread Daniel Vetter
On Mon, May 18, 2020 at 12:11:32PM +0200, Gerd Hoffmann wrote: > On Mon, May 18, 2020 at 10:50:15AM +0200, Thomas Zimmermann wrote: > > Hi Gerd > > > > Am 18.05.20 um 10:23 schrieb Gerd Hoffmann: > > >>> $ git grep drm_gem_shmem_mmap > > >>> > > >>> We also need correct access from userspace, othe

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-18 Thread Gerd Hoffmann
On Mon, May 18, 2020 at 10:50:15AM +0200, Thomas Zimmermann wrote: > Hi Gerd > > Am 18.05.20 um 10:23 schrieb Gerd Hoffmann: > >>> $ git grep drm_gem_shmem_mmap > >>> > >>> We also need correct access from userspace, otherwise the gpu is going to > >>> be sad. > >> > >> I've been thinking about th

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-18 Thread Thomas Zimmermann
Hi Gerd Am 18.05.20 um 10:23 schrieb Gerd Hoffmann: >>> $ git grep drm_gem_shmem_mmap >>> >>> We also need correct access from userspace, otherwise the gpu is going to >>> be sad. >> >> I've been thinking about this, and I think it means that we can never >> have cached mappings anywhere. Even if

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-18 Thread Gerd Hoffmann
> > $ git grep drm_gem_shmem_mmap > > > > We also need correct access from userspace, otherwise the gpu is going to > > be sad. > > I've been thinking about this, and I think it means that we can never > have cached mappings anywhere. Even if shmem supports it internally for > most drivers, as so

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-18 Thread Thomas Zimmermann
Hi Am 15.05.20 um 16:10 schrieb Daniel Vetter: > On Fri, May 15, 2020 at 08:58:02AM +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 14.05.20 um 22:36 schrieb Rob Herring: >>> On Thu, May 14, 2020 at 7:40 AM Daniel Vetter wrote: On Wed, May 13, 2020 at 05:03:11PM +0200, Thomas Zimmermann

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-15 Thread Daniel Vetter
On Fri, May 15, 2020 at 08:58:02AM +0200, Thomas Zimmermann wrote: > Hi > > Am 14.05.20 um 22:36 schrieb Rob Herring: > > On Thu, May 14, 2020 at 7:40 AM Daniel Vetter wrote: > >> > >> On Wed, May 13, 2020 at 05:03:11PM +0200, Thomas Zimmermann wrote: > >>> SHMEM-buffer backing storage is allocat

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-14 Thread Thomas Zimmermann
Hi Am 14.05.20 um 22:36 schrieb Rob Herring: > On Thu, May 14, 2020 at 7:40 AM Daniel Vetter wrote: >> >> On Wed, May 13, 2020 at 05:03:11PM +0200, Thomas Zimmermann wrote: >>> SHMEM-buffer backing storage is allocated from system memory; which is >>> typically cachable. Currently, only virtio us

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-14 Thread Rob Herring
On Thu, May 14, 2020 at 7:40 AM Daniel Vetter wrote: > > On Wed, May 13, 2020 at 05:03:11PM +0200, Thomas Zimmermann wrote: > > SHMEM-buffer backing storage is allocated from system memory; which is > > typically cachable. Currently, only virtio uses cachable mappings; udl > > uses its own vmap/mm

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-14 Thread Thomas Zimmermann
Hi Am 14.05.20 um 14:40 schrieb Daniel Vetter: > On Wed, May 13, 2020 at 05:03:11PM +0200, Thomas Zimmermann wrote: >> SHMEM-buffer backing storage is allocated from system memory; which is >> typically cachable. Currently, only virtio uses cachable mappings; udl >> uses its own vmap/mmap implemen

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-14 Thread Daniel Vetter
On Wed, May 13, 2020 at 05:03:11PM +0200, Thomas Zimmermann wrote: > SHMEM-buffer backing storage is allocated from system memory; which is > typically cachable. Currently, only virtio uses cachable mappings; udl > uses its own vmap/mmap implementation for cachable mappings. Other > drivers default

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-13 Thread Thomas Zimmermann
Am 13.05.20 um 17:03 schrieb Thomas Zimmermann: > SHMEM-buffer backing storage is allocated from system memory; which is > typically cachable. Currently, only virtio uses cachable mappings; udl > uses its own vmap/mmap implementation for cachable mappings. Other > drivers default to writecombine

[PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-13 Thread Thomas Zimmermann
SHMEM-buffer backing storage is allocated from system memory; which is typically cachable. Currently, only virtio uses cachable mappings; udl uses its own vmap/mmap implementation for cachable mappings. Other drivers default to writecombine mappings. Use cached mappings by default. The exception i