Re: [PATCH 1/2] drm/scheduler: only kill entity if last user is killed v2

2018-07-31 Thread Nayan Deshmukh
That makes sense. The change is Acked-by: Nayan Deshmukh < nayan26deshm...@gmail.com> On Tue, Jul 31, 2018 at 2:12 AM Andrey Grodzovsky wrote: > I believe that in this case > > if (!entity->rq) { > > DRM_ERROR... > > return; > > } > > clause will take place. > > P.S I remember we planned

Re: [PATCH 1/2] drm/scheduler: only kill entity if last user is killed v2

2018-07-30 Thread Andrey Grodzovsky
I believe that in this case if (!entity->rq) {     DRM_ERROR...     return; } clause will take place. P.S I remember we planned to actually propagate the error back to the caller so i guess we should take care of this sooner or later. The change is Reviewed-by: Andrey Grodzovsky Andrey

Re: [PATCH 1/2] drm/scheduler: only kill entity if last user is killed v2

2018-07-30 Thread Nayan Deshmukh
Hi Christian, The code looks good to me. But I was just wondering what will happen when the last user is killed and some other user tries to push to the entity. Regards, Nayan Deshmukh On Mon, Jul 30, 2018 at 4:33 PM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Note which task i

[PATCH 1/2] drm/scheduler: only kill entity if last user is killed v2

2018-07-30 Thread Christian König
Note which task is using the entity and only kill it if the last user of the entity is killed. This should prevent problems when entities are leaked to child processes. v2: add missing kernel doc Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 6 +- include/dr