Re: [PATCH 1/2] drm/radeon: Use pci_dma_mapping_error()

2011-04-28 Thread Aurelien Jarno
On Wed, Apr 27, 2011 at 05:49:50PM +1000, Dave Airlie wrote: > On Wed, Apr 27, 2011 at 3:34 PM, Aurelien Jarno wrote: > > ... instead of comparing with DMA_ERROR_CODE, which will only work on > > powerpc/sparc/x86. > > > > So you wrote a patch that breaks it everwhere? It seems I inverted the co

[PATCH 1/2] drm/radeon: Use pci_dma_mapping_error()

2011-04-27 Thread Dave Airlie
On Wed, Apr 27, 2011 at 3:34 PM, Aurelien Jarno wrote: > ... instead of comparing with DMA_ERROR_CODE, which will only work on > powerpc/sparc/x86. > So you wrote a patch that breaks it everwhere? You might want to actually boot this sort of thing before I do, or read the interface for pci_dma_m

[PATCH 1/2] drm/radeon: Use pci_dma_mapping_error()

2011-04-27 Thread Aurelien Jarno
On Wed, Apr 27, 2011 at 05:49:50PM +1000, Dave Airlie wrote: > On Wed, Apr 27, 2011 at 3:34 PM, Aurelien Jarno > wrote: > > ... instead of comparing with DMA_ERROR_CODE, which will only work on > > powerpc/sparc/x86. > > > > So you wrote a patch that breaks it everwhere? It seems I inverted the

[PATCH 1/2] drm/radeon: Use pci_dma_mapping_error()

2011-04-27 Thread Aurelien Jarno
... instead of comparing with DMA_ERROR_CODE, which will only work on powerpc/sparc/x86. Signed-off-by: Aurelien Jarno --- drivers/gpu/drm/radeon/radeon_gart.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_gart.c b/drivers/gpu/drm/radeon

Re: [PATCH 1/2] drm/radeon: Use pci_dma_mapping_error()

2011-04-27 Thread Dave Airlie
On Wed, Apr 27, 2011 at 3:34 PM, Aurelien Jarno wrote: > ... instead of comparing with DMA_ERROR_CODE, which will only work on > powerpc/sparc/x86. > So you wrote a patch that breaks it everwhere? You might want to actually boot this sort of thing before I do, or read the interface for pci_dma_m

[PATCH 1/2] drm/radeon: Use pci_dma_mapping_error()

2011-04-26 Thread Aurelien Jarno
... instead of comparing with DMA_ERROR_CODE, which will only work on powerpc/sparc/x86. Signed-off-by: Aurelien Jarno --- drivers/gpu/drm/radeon/radeon_gart.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_gart.c b/drivers/gpu/drm/radeon