Re: [PATCH 1/2] drm/panthor: Fix missing explicit padding in drm_panthor_gpu_info

2025-04-17 Thread Liviu Dudau
On Thu, Apr 17, 2025 at 12:05:02PM +0200, Boris Brezillon wrote: > drm_panthor_gpu_info::shader_present is currently automatically offset > by 4 byte to meet Arm's 32-bit/64-bit field alignment rules, but those > constraints don't stand on 32-bit x86 and cause a mismatch when running > an x86 binar

Re: [PATCH 1/2] drm/panthor: Fix missing explicit padding in drm_panthor_gpu_info

2025-04-17 Thread Boris Brezillon
On Thu, 17 Apr 2025 11:24:32 +0100 Steven Price wrote: > On 17/04/2025 11:05, Boris Brezillon wrote: > > drm_panthor_gpu_info::shader_present is currently automatically offset > > by 4 byte to meet Arm's 32-bit/64-bit field alignment rules, but those > > constraints don't stand on 32-bit x86 and

Re: [PATCH 1/2] drm/panthor: Fix missing explicit padding in drm_panthor_gpu_info

2025-04-17 Thread Steven Price
On 17/04/2025 11:05, Boris Brezillon wrote: > drm_panthor_gpu_info::shader_present is currently automatically offset > by 4 byte to meet Arm's 32-bit/64-bit field alignment rules, but those > constraints don't stand on 32-bit x86 and cause a mismatch when running > an x86 binary in a user emulated

[PATCH 1/2] drm/panthor: Fix missing explicit padding in drm_panthor_gpu_info

2025-04-17 Thread Boris Brezillon
drm_panthor_gpu_info::shader_present is currently automatically offset by 4 byte to meet Arm's 32-bit/64-bit field alignment rules, but those constraints don't stand on 32-bit x86 and cause a mismatch when running an x86 binary in a user emulated environment like FEX. It's also generally agreed tha