Re: [PATCH 1/2] drm/omapdrm: drop fb_debug_enter/leave

2019-06-12 Thread Daniel Vetter
On Wed, Jun 12, 2019 at 11:19 AM Tomi Valkeinen wrote: > > On 12/06/2019 12:12, Daniel Vetter wrote: > > This is a no-op on atomic drivers because with atomic it's simply too > > complicated to get all the locking and workers and nonblocking > > synchronization correct, from essentially an NMI con

Re: [PATCH 1/2] drm/omapdrm: drop fb_debug_enter/leave

2019-06-12 Thread Tomi Valkeinen
On 12/06/2019 12:12, Daniel Vetter wrote: This is a no-op on atomic drivers because with atomic it's simply too complicated to get all the locking and workers and nonblocking synchronization correct, from essentially an NMI context. Well, too complicated = impossible. Also, omapdrm never implemen

[PATCH 1/2] drm/omapdrm: drop fb_debug_enter/leave

2019-06-12 Thread Daniel Vetter
This is a no-op on atomic drivers because with atomic it's simply too complicated to get all the locking and workers and nonblocking synchronization correct, from essentially an NMI context. Well, too complicated = impossible. Also, omapdrm never implemented the mode_set_base_atomic hook, so I kind