Re: [PATCH 1/2] drm/msm: simplify getting .driver_data

2019-03-22 Thread Wolfram Sang
> > - struct platform_device *pdev = to_platform_device(dev); > > - struct msm_gpu *gpu = platform_get_drvdata(pdev); > > + struct msm_gpu *gpu = dev_get_drvdata(dev); > > Nice simplification :-) > > Do you catch these with Coccinelle? Yes, the previous series had the script in the cover

Re: [PATCH 1/2] drm/msm: simplify getting .driver_data

2019-03-22 Thread Kieran Bingham
Hi Wolfram, Thank you for the patch, On 19/03/2019 16:36, Wolfram Sang wrote: > We should get 'driver_data' from 'struct device' directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang This looks good to me. Reviewed-by: Kieran Bingham > ---

[PATCH 1/2] drm/msm: simplify getting .driver_data

2019-03-19 Thread Wolfram Sang
We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. drivers/gpu/drm/msm/adreno/adreno_device.c | 6 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c| 13