[PATCH 1/2] drm/gem: simplify object initialization

2013-07-11 Thread Patrik Jakobsson
On Thu, Jul 11, 2013 at 11:56 AM, David Herrmann wrote: > drm_gem_object_init() and drm_gem_private_object_init() do exactly the > same (except for shmem alloc) so make the first use the latter to reduce > code duplication. > > Also drop the return code from drm_gem_private_object_init(). It seem

[PATCH 1/2] drm/gem: simplify object initialization

2013-07-11 Thread Daniel Vetter
On Thu, Jul 11, 2013 at 11:56:32AM +0200, David Herrmann wrote: > drm_gem_object_init() and drm_gem_private_object_init() do exactly the > same (except for shmem alloc) so make the first use the latter to reduce > code duplication. > > Also drop the return code from drm_gem_private_object_init().

[PATCH 1/2] drm/gem: simplify object initialization

2013-07-11 Thread David Herrmann
drm_gem_object_init() and drm_gem_private_object_init() do exactly the same (except for shmem alloc) so make the first use the latter to reduce code duplication. Also drop the return code from drm_gem_private_object_init(). It seems unlikely that we will extend it any time soon so no reason to kee

[PATCH 1/2] drm/gem: simplify object initialization

2013-07-11 Thread Chris Wilson
On Thu, Jul 11, 2013 at 11:56:32AM +0200, David Herrmann wrote: > drm_gem_object_init() and drm_gem_private_object_init() do exactly the > same (except for shmem alloc) so make the first use the latter to reduce > code duplication. > > Also drop the return code from drm_gem_private_object_init().

[PATCH 1/2] drm/gem: simplify object initialization

2013-07-11 Thread Rob Clark
On Thu, Jul 11, 2013 at 5:56 AM, David Herrmann wrote: > drm_gem_object_init() and drm_gem_private_object_init() do exactly the > same (except for shmem alloc) so make the first use the latter to reduce > code duplication. > > Also drop the return code from drm_gem_private_object_init(). It seems

Re: [PATCH 1/2] drm/gem: simplify object initialization

2013-07-11 Thread Rob Clark
On Thu, Jul 11, 2013 at 5:56 AM, David Herrmann wrote: > drm_gem_object_init() and drm_gem_private_object_init() do exactly the > same (except for shmem alloc) so make the first use the latter to reduce > code duplication. > > Also drop the return code from drm_gem_private_object_init(). It seems

Re: [PATCH 1/2] drm/gem: simplify object initialization

2013-07-11 Thread Patrik Jakobsson
On Thu, Jul 11, 2013 at 11:56 AM, David Herrmann wrote: > drm_gem_object_init() and drm_gem_private_object_init() do exactly the > same (except for shmem alloc) so make the first use the latter to reduce > code duplication. > > Also drop the return code from drm_gem_private_object_init(). It seems

Re: [PATCH 1/2] drm/gem: simplify object initialization

2013-07-11 Thread Daniel Vetter
On Thu, Jul 11, 2013 at 11:56:32AM +0200, David Herrmann wrote: > drm_gem_object_init() and drm_gem_private_object_init() do exactly the > same (except for shmem alloc) so make the first use the latter to reduce > code duplication. > > Also drop the return code from drm_gem_private_object_init().

Re: [PATCH 1/2] drm/gem: simplify object initialization

2013-07-11 Thread Chris Wilson
On Thu, Jul 11, 2013 at 11:56:32AM +0200, David Herrmann wrote: > drm_gem_object_init() and drm_gem_private_object_init() do exactly the > same (except for shmem alloc) so make the first use the latter to reduce > code duplication. > > Also drop the return code from drm_gem_private_object_init().

[PATCH 1/2] drm/gem: simplify object initialization

2013-07-11 Thread David Herrmann
drm_gem_object_init() and drm_gem_private_object_init() do exactly the same (except for shmem alloc) so make the first use the latter to reduce code duplication. Also drop the return code from drm_gem_private_object_init(). It seems unlikely that we will extend it any time soon so no reason to kee