Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-12-14 Thread Imre Deak
On Fri, Dec 11, 2020 at 09:04:02AM +0200, Chery, Nanley G wrote: > [...] > > > We probably don't have to update the header, but we noticed in our > > > testing that the clear color prefers an alignment greater than 64B. > > > Unfortunately, I can't find any bspec note about this. As long as the > >

RE: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-12-10 Thread Chery, Nanley G
n ; Pandiyan, Dhinakaran > ; dri-devel@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for > Intel Gen 12 render compression with Clear Color > > Hi Nanley, > > thanks for the review. > > +Ville, Chris. > > On Tue, Dec 01

Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-12-01 Thread Imre Deak
Hi Nanley, thanks for the review. +Ville, Chris. On Tue, Dec 01, 2020 at 02:18:26AM +0200, Chery, Nanley G wrote: > Hi Imre, > > I have a question and a couple comments: > > Is the map of the clear color address creating a new synchronization > point between the GPU and CPU? If so, I wonder h

RE: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-11-30 Thread Chery, Nanley G
iyan, Dhinakaran > ; dri-devel@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for > Intel > Gen 12 render compression with Clear Color > > On Fri, Nov 27, 2020 at 04:19:20PM +0100, Daniel Vetter wrote: > > On Fri, Nov 27, 2020 at 04

Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-11-30 Thread Jani Nikula
On Fri, 27 Nov 2020, Daniel Vetter wrote: > On Fri, Nov 27, 2020 at 04:31:00PM +0200, Imre Deak wrote: >> Hi Daniel, Jani, >> >> is it ok to merge this patch along with 2/2 via the i915 tree? > > Ack from mesa (userspace in general, but mesa is kinda mandatory) is > missing I think. With that > >

Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-11-27 Thread Imre Deak
On Fri, Nov 27, 2020 at 04:19:20PM +0100, Daniel Vetter wrote: > On Fri, Nov 27, 2020 at 04:31:00PM +0200, Imre Deak wrote: > > Hi Daniel, Jani, > > > > is it ok to merge this patch along with 2/2 via the i915 tree? > > Ack from mesa (userspace in general, but mesa is kinda mandatory) is > missin

Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-11-27 Thread Daniel Vetter
On Fri, Nov 27, 2020 at 04:31:00PM +0200, Imre Deak wrote: > Hi Daniel, Jani, > > is it ok to merge this patch along with 2/2 via the i915 tree? Ack from mesa (userspace in general, but mesa is kinda mandatory) is missing I think. With that Acked-by: Daniel Vetter > > --Imre > > On Mon, Nov

Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-11-27 Thread Imre Deak
Hi Daniel, Jani, is it ok to merge this patch along with 2/2 via the i915 tree? --Imre On Mon, Nov 23, 2020 at 08:26:30PM +0200, Imre Deak wrote: > From: Radhakrishna Sripada > > Gen12 display can decompress surfaces compressed by render engine with > Clear Color, add a new modifier as the dri

Re: [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen-12 render compression

2019-09-07 Thread Dhinakaran Pandiyan
On Sat, 2019-09-07 at 00:21 -0700, Dhinakaran Pandiyan wrote: > Gen-12 has a new compression format, add a new modifier to indicate that. > > Cc: Ville Syrjälä > Cc: Matt Roper > Cc: Nanley G Chery > Cc: Jason Ekstrand Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Dhinakaran Pandiyan