Re: [PATCH 1/2] drm/edid: Use unsigned int in drm_add_modes_noedid()

2025-03-30 Thread Jani Nikula
On Tue, 25 Mar 2025, Lyude Paul wrote: > A negative resolution doesn't really make any sense, no one goes into a TV > store and says "Hello sir, I would like a negative 4K TV please", that > would make everyone look at you funny. That is largely the point, though. You know something fishy is goin

Re: [PATCH 1/2] drm/edid: Use unsigned int in drm_add_modes_noedid()

2025-03-29 Thread Miguel Ojeda
On Fri, Mar 28, 2025 at 11:27 PM Lyude Paul wrote: > > So - it actually does protect us to a limited extent on the rust side of > things. With CONFIG_RUST_OVERFLOW_CHECKS=y, arithematic checks are builtin to > the language. This isn't the default config of course, but it's better then > nothing.

Re: [PATCH 1/2] drm/edid: Use unsigned int in drm_add_modes_noedid()

2025-03-28 Thread Lyude Paul
On Wed, 2025-03-26 at 12:39 +0200, Jani Nikula wrote: > On Tue, 25 Mar 2025, Lyude Paul wrote: > > A negative resolution doesn't really make any sense, no one goes into a TV > > store and says "Hello sir, I would like a negative 4K TV please", that > > would make everyone look at you funny. > > T

Re: [PATCH 1/2] drm/edid: Use unsigned int in drm_add_modes_noedid()

2025-03-26 Thread Miguel Ojeda
On Wed, Mar 26, 2025 at 11:39 AM Jani Nikula wrote: > > That is largely the point, though. You know something fishy is going on > when you have a negative resolution. Nobody blinks an eye when you ask > for 4294963K telly, but it's still just as bonkers as that negative 4K. > > I think the change

Re: [PATCH 1/2] drm/edid: Use unsigned int in drm_add_modes_noedid()

2025-03-26 Thread Thomas Zimmermann
Hi Am 25.03.25 um 22:27 schrieb Lyude Paul: A negative resolution doesn't really make any sense, no one goes into a TV store and says "Hello sir, I would like a negative 4K TV please", that would make everyone look at you funny. So, let's make these parameters a bit more reasonable and ensure t

[PATCH 1/2] drm/edid: Use unsigned int in drm_add_modes_noedid()

2025-03-25 Thread Lyude Paul
A negative resolution doesn't really make any sense, no one goes into a TV store and says "Hello sir, I would like a negative 4K TV please", that would make everyone look at you funny. So, let's make these parameters a bit more reasonable and ensure that they're unsigned - which makes the resultin