Re: [PATCH 1/2] drm/atomic: Initialise planes with opaque alpha values

2018-09-20 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Wednesday, 19 September 2018 18:56:58 EEST Kieran Bingham wrote: > Planes without an alpha property, using __drm_atomic_helper_plane_reset > will have their plane state alpha initialised as zero, which represents > a transparent alpha. > > If this value is

Re: [PATCH 1/2] drm/atomic: Initialise planes with opaque alpha values

2018-09-20 Thread Alexandru-Cosmin Gheorghe
On Thu, Sep 20, 2018 at 11:03:12AM +0100, Kieran Bingham wrote: > Hi Alexandru, > > On 19/09/18 17:43, Alexandru-Cosmin Gheorghe wrote: > > Hi Kieran, > > > > > > On Wed, Sep 19, 2018 at 07:15:45PM +0300, Ville Syrjälä wrote: > >> On Wed, Sep 19, 2018 at 04:56:58PM +0100, Kieran Bingham wrote: >

Re: [PATCH 1/2] drm/atomic: Initialise planes with opaque alpha values

2018-09-20 Thread Kieran Bingham
Hi Alexandru, On 19/09/18 17:43, Alexandru-Cosmin Gheorghe wrote: > Hi Kieran, > > > On Wed, Sep 19, 2018 at 07:15:45PM +0300, Ville Syrjälä wrote: >> On Wed, Sep 19, 2018 at 04:56:58PM +0100, Kieran Bingham wrote: >>> Planes without an alpha property, using __drm_atomic_helper_plane_reset >>> w

Re: [PATCH 1/2] drm/atomic: Initialise planes with opaque alpha values

2018-09-19 Thread Alexandru-Cosmin Gheorghe
Hi Kieran, On Wed, Sep 19, 2018 at 07:15:45PM +0300, Ville Syrjälä wrote: > On Wed, Sep 19, 2018 at 04:56:58PM +0100, Kieran Bingham wrote: > > Planes without an alpha property, using __drm_atomic_helper_plane_reset > > will have their plane state alpha initialised as zero, which represents > > a

Re: [PATCH 1/2] drm/atomic: Initialise planes with opaque alpha values

2018-09-19 Thread Ville Syrjälä
On Wed, Sep 19, 2018 at 04:56:58PM +0100, Kieran Bingham wrote: > Planes without an alpha property, using __drm_atomic_helper_plane_reset > will have their plane state alpha initialised as zero, which represents > a transparent alpha. > > If this value is then used for the plane, it may not be vis

[PATCH 1/2] drm/atomic: Initialise planes with opaque alpha values

2018-09-19 Thread Kieran Bingham
Planes without an alpha property, using __drm_atomic_helper_plane_reset will have their plane state alpha initialised as zero, which represents a transparent alpha. If this value is then used for the plane, it may not be visible by default, and thus doesn't represent a good initialisation state.