Re: [PATCH 1/2] coda: fix reference counting in coda_file_mmap error path

2021-04-23 Thread Christian König
Am 22.04.21 um 15:51 schrieb Jan Harkes: On Thu, Apr 22, 2021 at 02:39:41PM +0200, Christian König wrote: Am 22.04.21 um 14:27 schrieb Jan Harkes: Looks good to me. I'm also maintaining an out of tree coda module build that people sometimes use, which has workarounds for differences between t

Re: [PATCH 1/2] coda: fix reference counting in coda_file_mmap error path

2021-04-22 Thread Jan Harkes
Looks good to me. I'm also maintaining an out of tree coda module build that people sometimes use, which has workarounds for differences between the various kernel versions. Do you have a reference to the corresponding mmap_region change? If it is merged already I'll probably be able to find it

Re: [PATCH 1/2] coda: fix reference counting in coda_file_mmap error path

2021-04-22 Thread Jan Harkes
On Thu, Apr 22, 2021 at 02:39:41PM +0200, Christian König wrote: > Am 22.04.21 um 14:27 schrieb Jan Harkes: > > Looks good to me. > > > > I'm also maintaining an out of tree coda module build that people sometimes > > use, which has workarounds for differences between the various kernel > > vers

Re: [PATCH 1/2] coda: fix reference counting in coda_file_mmap error path

2021-04-22 Thread Christian König
Hi Jan, Am 22.04.21 um 14:27 schrieb Jan Harkes: Looks good to me. I'm also maintaining an out of tree coda module build that people sometimes use, which has workarounds for differences between the various kernel versions. Do you have a reference to the corresponding mmap_region change? If it

Re: [PATCH 1/2] coda: fix reference counting in coda_file_mmap error path

2021-04-22 Thread Daniel Vetter
On Wed, Apr 21, 2021 at 03:20:11PM +0200, Christian König wrote: > mmap_region() now calls fput() on the vma->vm_file. > > So we need to drop the extra reference on the coda file instead of the > host file. > > Signed-off-by: Christian König > Fixes: 1527f926fd04 ("mm: mmap: fix fput in error pa

[PATCH 1/2] coda: fix reference counting in coda_file_mmap error path

2021-04-21 Thread Christian König
mmap_region() now calls fput() on the vma->vm_file. So we need to drop the extra reference on the coda file instead of the host file. Signed-off-by: Christian König Fixes: 1527f926fd04 ("mm: mmap: fix fput in error path v2") CC: sta...@vger.kernel.org # 5.11+ --- fs/coda/file.c | 6 +++--- 1 fi