Re: [PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-15 Thread Andreas Kemnade
Hi, On Sun, 15 Sep 2019 18:52:04 +0200 Pavel Machek wrote: > Hi! > > > > > > Is this needed? > > > > > > > > > > This is a remove path, not a power management path, and we have no > > > > > idea > > > > > what the original status of the pin was anyway? > > > > > > > > > > > > > Looking

Re: [PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-15 Thread Pavel Machek
Hi! > > > > Is this needed? > > > > > > > > This is a remove path, not a power management path, and we have no idea > > > > what the original status of the pin was anyway? > > > > > > > > > > Looking at Ishdn on page 5 of the datasheet, switching it off everytime > > > possible seems not need

Re: [PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-10 Thread Andreas Kemnade
On Tue, 10 Sep 2019 11:21:56 +0100 Daniel Thompson wrote: [...] > > > Is this needed? > > > > > > This is a remove path, not a power management path, and we have no idea > > > what the original status of the pin was anyway? > > > > > > > Looking at Ishdn on page 5 of the datasheet, switching

Re: [PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-10 Thread Daniel Thompson
On Mon, Sep 09, 2019 at 10:13:49PM +0200, Andreas Kemnade wrote: > On Mon, 9 Sep 2019 11:57:29 +0100 > Daniel Thompson wrote: > > > On Sun, Sep 08, 2019 at 10:37:03PM +0200, Andreas Kemnade wrote: > > > For now just enable it in the probe function to allow i2c > > > access and disable it on remov

Re: [PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-09 Thread Andreas Kemnade
On Mon, 9 Sep 2019 11:57:29 +0100 Daniel Thompson wrote: > On Sun, Sep 08, 2019 at 10:37:03PM +0200, Andreas Kemnade wrote: > > For now just enable it in the probe function to allow i2c > > access and disable it on remove. Disabling also means resetting > > the register values to default. > > >

Re: [PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-09 Thread Daniel Thompson
On Sun, Sep 08, 2019 at 10:37:03PM +0200, Andreas Kemnade wrote: > For now just enable it in the probe function to allow i2c > access and disable it on remove. Disabling also means resetting > the register values to default. > > Tested on Kobo Clara HD. > > Signed-off-by: Andreas Kemnade > --- >

[PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-09 Thread Andreas Kemnade
For now just enable it in the probe function to allow i2c access and disable it on remove. Disabling also means resetting the register values to default. Tested on Kobo Clara HD. Signed-off-by: Andreas Kemnade --- drivers/video/backlight/lm3630a_bl.c | 18 ++ 1 file changed, 18