RE: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-12 Thread Michael Kelley
From: Saurabh Singh Sengar Sent: Wednesday, February 12, 2025 7:07 PM > > On Thu, Feb 13, 2025 at 01:35:22AM +, Michael Kelley wrote: > > From: Saurabh Singh Sengar Sent: Monday, > > February 10, 2025 8:52 AM > > > > > [snip] > > > > > > > > > > > > While we are at it, I want to mention th

Re: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-12 Thread Saurabh Singh Sengar
On Thu, Feb 13, 2025 at 01:35:22AM +, Michael Kelley wrote: > From: Saurabh Singh Sengar Sent: Monday, > February 10, 2025 8:52 AM > > > [snip] > > > > > > > > > > While we are at it, I want to mention that I also observed below WARN > > > > > while removing the hyperv_fb, but that needs a s

RE: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-12 Thread Michael Kelley
From: Saurabh Singh Sengar Sent: Monday, February 10, 2025 8:52 AM > [snip] > > > > > > > > While we are at it, I want to mention that I also observed below WARN > > > > while removing the hyperv_fb, but that needs a separate fix. > > > > > > > > > > > > [ 44.111220] WARNING: CPU: 35 PID: 1882

Re: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-11 Thread Wei Liu
On Sun, Feb 09, 2025 at 03:52:52PM -0800, mhkelle...@gmail.com wrote: > From: Michael Kelley > > When a Hyper-V framebuffer device is removed, or the driver is unbound > from a device, any allocated and/or mapped memory must be released. In > particular, MMIO address space that was mapped to the

RE: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-10 Thread Michael Kelley
From: Saurabh Singh Sengar Sent: Monday, February 10, 2025 8:52 AM > > On Mon, Feb 10, 2025 at 06:58:25AM -0800, Saurabh Singh Sengar wrote: > > On Mon, Feb 10, 2025 at 02:28:35PM +, Michael Kelley wrote: > > > From: Saurabh Singh Sengar Sent: Monday, > > > February 10, 2025 4:41 AM > > >

Re: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-10 Thread Saurabh Singh Sengar
On Mon, Feb 10, 2025 at 06:58:25AM -0800, Saurabh Singh Sengar wrote: > On Mon, Feb 10, 2025 at 02:28:35PM +, Michael Kelley wrote: > > From: Saurabh Singh Sengar Sent: Monday, > > February 10, 2025 4:41 AM > > > > > > On Sun, Feb 09, 2025 at 03:52:52PM -0800, mhkelle...@gmail.com wrote: > >

Re: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-10 Thread Saurabh Singh Sengar
On Mon, Feb 10, 2025 at 02:28:35PM +, Michael Kelley wrote: > From: Saurabh Singh Sengar Sent: Monday, > February 10, 2025 4:41 AM > > > > On Sun, Feb 09, 2025 at 03:52:52PM -0800, mhkelle...@gmail.com wrote: > > > From: Michael Kelley > > > > > > When a Hyper-V framebuffer device is remove

RE: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-10 Thread Michael Kelley
From: Saurabh Singh Sengar Sent: Monday, February 10, 2025 4:41 AM > > On Sun, Feb 09, 2025 at 03:52:52PM -0800, mhkelle...@gmail.com wrote: > > From: Michael Kelley > > > > When a Hyper-V framebuffer device is removed, or the driver is unbound > > from a device, any allocated and/or mapped mem

Re: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-10 Thread Saurabh Singh Sengar
On Sun, Feb 09, 2025 at 03:52:52PM -0800, mhkelle...@gmail.com wrote: > From: Michael Kelley > > When a Hyper-V framebuffer device is removed, or the driver is unbound > from a device, any allocated and/or mapped memory must be released. In > particular, MMIO address space that was mapped to the

[PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-09 Thread mhkelley58
From: Michael Kelley When a Hyper-V framebuffer device is removed, or the driver is unbound from a device, any allocated and/or mapped memory must be released. In particular, MMIO address space that was mapped to the framebuffer must be unmapped. Current code unmaps the wrong address, resulting i