[PATCH 1/1] drm/sti: fix master bind bug for using component

2015-07-16 Thread Xinwei Kong
hi ben: your patch is ok, i don't know your hardware how to use. In this first code why use that style dts? If you detail research our patch, you will find that it can compatiable your fixing dts. If you don't approve our patch better, I will be glad to see you to slove this bug Thank you Xinwei

[PATCH 1/1] drm/sti: fix master bind bug for using component

2015-07-16 Thread Benjamin Gaignard
This patch isn't the good one, I send the fix here: http://lists.freedesktop.org/archives/dri-devel/2015-July/086568.html Regards, Benjamin 2015-07-16 3:13 GMT+02:00 Xinwei Kong : > Thank you for Russel. > > It is Right, when this sti_tvout (component) finish executing component > ".bind" > func

[PATCH 1/1] drm/sti: fix master bind bug for using component

2015-07-16 Thread Xinwei Kong
Thank you for Russel. It is Right, when this sti_tvout (component) finish executing component ".bind" function while sti_hdmi or sti_hda is not registered. the bug will occur . this patch will prepare this bug by calling master .bind of sti_tvout after sti_hdmi or sti_hda is register to finish bi

[PATCH 1/1] drm/sti: fix master bind bug for using component

2015-07-15 Thread Benjamin Gaignard
Thanks a lot Russell, I have now understand where was my mistake. 2015-07-15 12:42 GMT+02:00 Russell King - ARM Linux : > On Wed, Jul 15, 2015 at 12:19:01PM +0200, Benjamin Gaignard wrote: >> The build order in Makefile hasn't been change so the bug doesn't occur... >> >> In addition of taking ca

[PATCH 1/1] drm/sti: fix master bind bug for using component

2015-07-15 Thread Benjamin Gaignard
The build order in Makefile hasn't been change so the bug doesn't occur... In addition of taking care of not changing build order in Makefile, I would like to understand what is the expected behavior of component framework when master call component_bind_all() before any component_add() calls. Sh

[PATCH 1/1] drm/sti: fix master bind bug for using component

2015-07-15 Thread Russell King - ARM Linux
On Wed, Jul 15, 2015 at 12:19:01PM +0200, Benjamin Gaignard wrote: > The build order in Makefile hasn't been change so the bug doesn't occur... > > In addition of taking care of not changing build order in Makefile, > I would like to understand what is the expected behavior of component > framewor

[PATCH 1/1] drm/sti: fix master bind bug for using component

2015-07-14 Thread Xinwei Kong
From: Xinwei Kong This patch fix one bug which it can't call .bind function in sti_hdmi.c and sti_hda.c file when changing the building sequence (sti_hdmi.o,sti_hda.o) in Makefile file. This patch can prepare it. Signed-off-by: Xinwei Kong --- drivers/gpu/drm/sti/sti_tvout.c | 17 +++