[PATCH 09/13] drm/fb-helper: Split dpms handling into legacy and atomic paths

2017-07-04 Thread Daniel Vetter
Like with panning and modesetting, and like with those, stick with simple drm_modeset_locking_all for the legacy path, and the full atomic dance for atomic drivers. This means a bit more boilerplate since setting up the atomic state machinery is rather verbose, but then this is shared code for 30+

Re: [PATCH 09/13] drm/fb-helper: Split dpms handling into legacy and atomic paths

2017-06-29 Thread Maarten Lankhorst
Op 29-06-17 om 13:00 schreef Daniel Vetter: > On Thu, Jun 29, 2017 at 12:58 PM, Maarten Lankhorst > wrote: >> Op 29-06-17 om 12:31 schreef Daniel Vetter: >>> On Thu, Jun 29, 2017 at 12:22 PM, Maarten Lankhorst >>> wrote: > +static void dpms_atomic(struct drm_fb_helper *fb_helper, int dpms_mod

Re: [PATCH 09/13] drm/fb-helper: Split dpms handling into legacy and atomic paths

2017-06-29 Thread Daniel Vetter
On Thu, Jun 29, 2017 at 12:58 PM, Maarten Lankhorst wrote: > Op 29-06-17 om 12:31 schreef Daniel Vetter: >> On Thu, Jun 29, 2017 at 12:22 PM, Maarten Lankhorst >> wrote: +static void dpms_atomic(struct drm_fb_helper *fb_helper, int dpms_mode) +{ + struct drm_device *dev = fb_he

Re: [PATCH 09/13] drm/fb-helper: Split dpms handling into legacy and atomic paths

2017-06-29 Thread Maarten Lankhorst
Op 29-06-17 om 12:31 schreef Daniel Vetter: > On Thu, Jun 29, 2017 at 12:22 PM, Maarten Lankhorst > wrote: >>> +static void dpms_atomic(struct drm_fb_helper *fb_helper, int dpms_mode) >>> +{ >>> + struct drm_device *dev = fb_helper->dev; >>> + struct drm_atomic_state *state; >>> + int

Re: [PATCH 09/13] drm/fb-helper: Split dpms handling into legacy and atomic paths

2017-06-29 Thread Daniel Vetter
On Thu, Jun 29, 2017 at 12:22 PM, Maarten Lankhorst wrote: >> +static void dpms_atomic(struct drm_fb_helper *fb_helper, int dpms_mode) >> +{ >> + struct drm_device *dev = fb_helper->dev; >> + struct drm_atomic_state *state; >> + int i, ret; >> + >> + struct drm_modeset_acquire_ctx

Re: [PATCH 09/13] drm/fb-helper: Split dpms handling into legacy and atomic paths

2017-06-29 Thread Maarten Lankhorst
Op 27-06-17 om 16:59 schreef Daniel Vetter: > Like with panning and modesetting, and like with those, stick with > simple drm_modeset_locking_all for the legacy path, and the full > atomic dance for atomic drivers. > > This means a bit more boilerplate since setting up the atomic state > machinery

[PATCH 09/13] drm/fb-helper: Split dpms handling into legacy and atomic paths

2017-06-27 Thread Daniel Vetter
Like with panning and modesetting, and like with those, stick with simple drm_modeset_locking_all for the legacy path, and the full atomic dance for atomic drivers. This means a bit more boilerplate since setting up the atomic state machinery is rather verbose, but then this is shared code for 30+