Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-17 Thread Andy Yan
Hi Jonas: On 11/18/23 07:46, Jonas Karlman wrote: On 2023-11-14 12:28, Andy Yan wrote: From: Andy Yan VOP2 on rk3588: Four video ports: VP0 Max 4096x2160 VP1 Max 4096x2160 VP2 Max 4096x2160 VP3 Max 2048x1080 4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support 4 4K Esmart windo

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-17 Thread Jonas Karlman
On 2023-11-14 12:28, Andy Yan wrote: > From: Andy Yan > > VOP2 on rk3588: > > Four video ports: > VP0 Max 4096x2160 > VP1 Max 4096x2160 > VP2 Max 4096x2160 > VP3 Max 2048x1080 > > 4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support > 4 4K Esmart windows with line RGB/YUV support >

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-17 Thread Sascha Hauer
On Fri, Nov 17, 2023 at 03:06:35PM +0800, Andy Yan wrote: > Hi Sebastian: > > On 11/16/23 21:47, Sebastian Reichel wrote: > > Hi, > > > > On Thu, Nov 16, 2023 at 06:39:40PM +0800, Andy Yan wrote: > > > > > vop2->sys_grf = syscon_regmap_lookup_by_phandle(dev->of_node, > > > > > "rockchip,gr

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-16 Thread Andy Yan
Hi Sebastian: On 11/16/23 21:47, Sebastian Reichel wrote: Hi, On Thu, Nov 16, 2023 at 06:39:40PM +0800, Andy Yan wrote: vop2->sys_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,grf"); This already lacks an error check, shame on me... + vop2->vop_grf = syscon_re

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-16 Thread Rob Herring
On Tue, Nov 14, 2023 at 07:28:55PM +0800, Andy Yan wrote: > From: Andy Yan > > VOP2 on rk3588: > > Four video ports: > VP0 Max 4096x2160 > VP1 Max 4096x2160 > VP2 Max 4096x2160 > VP3 Max 2048x1080 > > 4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support > 4 4K Esmart windows with l

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-16 Thread Sebastian Reichel
Hi, On Thu, Nov 16, 2023 at 06:39:40PM +0800, Andy Yan wrote: > > > vop2->sys_grf = syscon_regmap_lookup_by_phandle(dev->of_node, > > > "rockchip,grf"); > > This already lacks an error check, shame on me... > > > > > + vop2->vop_grf = syscon_regmap_lookup_by_phandle(dev->of_node, > >

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-16 Thread Andy Yan
Hi Sascha: Please check my response for the rest comments inline. On 11/15/23 17:08, Sascha Hauer wrote: Hi Andy, Thanks for your patches, some remarks inline. On Tue, Nov 14, 2023 at 07:28:55PM +0800, Andy Yan wrote: From: Andy Yan VOP2 on rk3588: Four video ports: VP0 Max 4096x2160 VP1

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-16 Thread Andy Yan
Hi Sascha: On 11/16/23 15:50, Sascha Hauer wrote: On Thu, Nov 16, 2023 at 03:24:54PM +0800, Andy Yan wrote: case ROCKCHIP_VOP2_EP_HDMI0: case ROCKCHIP_VOP2_EP_HDMI1: ... } would look a bit better overall. + /* +* K = 2: dclk_core

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-15 Thread Sascha Hauer
On Thu, Nov 16, 2023 at 03:24:54PM +0800, Andy Yan wrote: > > case ROCKCHIP_VOP2_EP_HDMI0: > > case ROCKCHIP_VOP2_EP_HDMI1: > > ... > > } > > > > would look a bit better overall. > > > > > + /* > > > + * K = 2: dclk_core = if_pixclk_rate > if_dclk_rate > > > +

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-15 Thread Andy Yan
Hi Sascha:  Thanks for your review.  Let's confirm your remarks in function vop2_calc_cru_cfg fist, others are small nits I think can be easy to address. On 11/15/23 17:08, Sascha Hauer wrote: Hi Andy, Thanks for your patches, some remarks inline. On Tue, Nov 14, 2023 at 07:28:55PM +0800, A

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-15 Thread Sascha Hauer
Hi Andy, Thanks for your patches, some remarks inline. On Tue, Nov 14, 2023 at 07:28:55PM +0800, Andy Yan wrote: > From: Andy Yan > > VOP2 on rk3588: > > Four video ports: > VP0 Max 4096x2160 > VP1 Max 4096x2160 > VP2 Max 4096x2160 > VP3 Max 2048x1080 > > 4 4K Cluster windows with AFBC/line R

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-15 Thread Heiko Stübner
Am Mittwoch, 15. November 2023, 03:02:42 CET schrieb Andy Yan: > Hi Heiko: > > On 11/15/23 07:34, Heiko Stübner wrote: > > Hi Andy, > > > > Am Dienstag, 14. November 2023, 12:28:55 CET schrieb Andy Yan: > >> From: Andy Yan > >> > >> VOP2 on rk3588: > >> > >> Four video ports: > >> VP0 Max 4096x21

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-14 Thread Andy Yan
Hi Heiko: On 11/15/23 07:34, Heiko Stübner wrote: Hi Andy, Am Dienstag, 14. November 2023, 12:28:55 CET schrieb Andy Yan: From: Andy Yan VOP2 on rk3588: Four video ports: VP0 Max 4096x2160 VP1 Max 4096x2160 VP2 Max 4096x2160 VP3 Max 2048x1080 4 4K Cluster windows with AFBC/line RGB and AFB

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-14 Thread Heiko Stübner
Hi Andy, Am Dienstag, 14. November 2023, 12:28:55 CET schrieb Andy Yan: > From: Andy Yan > > VOP2 on rk3588: > > Four video ports: > VP0 Max 4096x2160 > VP1 Max 4096x2160 > VP2 Max 4096x2160 > VP3 Max 2048x1080 > > 4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support > 4 4K Esmart

[PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-14 Thread Andy Yan
From: Andy Yan VOP2 on rk3588: Four video ports: VP0 Max 4096x2160 VP1 Max 4096x2160 VP2 Max 4096x2160 VP3 Max 2048x1080 4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support 4 4K Esmart windows with line RGB/YUV support Signed-off-by: Andy Yan --- drivers/gpu/drm/rockchip/rockc