Re: [PATCH 08/15] drm/sun4i: Fix polarity configuration for DW HDMI PHY

2018-02-27 Thread Jernej Škrabec
Hi, Dne ponedeljek, 26. februar 2018 ob 10:39:30 CET je Maxime Ripard napisal(a): > Hi, > > On Sat, Feb 24, 2018 at 10:45:38PM +0100, Jernej Skrabec wrote: > > Current polarity configuration code is cleary wrong since it compares > > same flag two times. However, even if flag name is fixed, it wo

Re: [PATCH 08/15] drm/sun4i: Fix polarity configuration for DW HDMI PHY

2018-02-26 Thread Maxime Ripard
Hi, On Sat, Feb 24, 2018 at 10:45:38PM +0100, Jernej Skrabec wrote: > Current polarity configuration code is cleary wrong since it compares > same flag two times. However, even if flag name is fixed, it won't work > well for resolutions which have one polarity positive and another > negative. > >

[PATCH 08/15] drm/sun4i: Fix polarity configuration for DW HDMI PHY

2018-02-26 Thread Jernej Skrabec
Current polarity configuration code is cleary wrong since it compares same flag two times. However, even if flag name is fixed, it won't work well for resolutions which have one polarity positive and another negative. Fix that by properly set each bit according to each polarity. Since those two bi