On Wed, Mar 28, 2012 at 3:14 AM, Chris Wilson
wrote:
> On Wed, 28 Mar 2012 02:36:17 +0800, Daniel Kurtz
> wrote:
>> A common method of probing an i2c bus is trying to do a zero-length write.
>> Handle this case by checking the length first before decrementing it.
>>
>> This is actually importan
On Wed, 28 Mar 2012 19:32:27 +0800, Daniel Kurtz
wrote:
> Unfortunately there is a bug in both my original patch (it wasn't
> incrementing loop), and in your suggested cleanup (it always
> decrements len, even when it is already 0... or if the loop test
> fails). How about the following; despite
On Wed, Mar 28, 2012 at 3:14 AM, Chris Wilson wrote:
> On Wed, 28 Mar 2012 02:36:17 +0800, Daniel Kurtz wrote:
>> A common method of probing an i2c bus is trying to do a zero-length write.
>> Handle this case by checking the length first before decrementing it.
>>
>> This is actually important, s
On Wed, 28 Mar 2012 19:32:27 +0800, Daniel Kurtz wrote:
> Unfortunately there is a bug in both my original patch (it wasn't
> incrementing loop), and in your suggested cleanup (it always
> decrements len, even when it is already 0... or if the loop test
> fails). How about the following; despite
A common method of probing an i2c bus is trying to do a zero-length write.
Handle this case by checking the length first before decrementing it.
This is actually important, since attempting a zero-length write is one
of the ways that i2cdetect and i2c_new_probed_device detect whether
there is devi
A common method of probing an i2c bus is trying to do a zero-length write.
Handle this case by checking the length first before decrementing it.
This is actually important, since attempting a zero-length write is one
of the ways that i2cdetect and i2c_new_probed_device detect whether
there is devi
On Wed, 28 Mar 2012 02:36:17 +0800, Daniel Kurtz
wrote:
> A common method of probing an i2c bus is trying to do a zero-length write.
> Handle this case by checking the length first before decrementing it.
>
> This is actually important, since attempting a zero-length write is one
> of the ways t
On Wed, 28 Mar 2012 02:36:17 +0800, Daniel Kurtz wrote:
> A common method of probing an i2c bus is trying to do a zero-length write.
> Handle this case by checking the length first before decrementing it.
>
> This is actually important, since attempting a zero-length write is one
> of the ways th
