Re: [PATCH 08/12] drm/ast: Factor mmc_test code in POST code

2017-02-24 Thread Joel Stanley
On Fri, Feb 24, 2017 at 9:23 AM, Benjamin Herrenschmidt wrote: > There's a some duplication for what's essentially copies of > two loops, so factor it. The upcoming AST2500 POST code adds > more of them. Also cleanup return types for the test functions, > most of them return a boolean, some return

RE: [PATCH 08/12] drm/ast: Factor mmc_test code in POST code

2017-02-23 Thread YC Chen
Tested-by: Y.C. Chen -Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Friday, February 24, 2017 6:54 AM To: dri-devel@lists.freedesktop.org Cc: YC Chen ; airl...@redhat.com; e...@suse.come; linuxppc-...@ozlabs.org Subject: [PATCH 08/12] drm/ast

[PATCH 08/12] drm/ast: Factor mmc_test code in POST code

2017-02-23 Thread Benjamin Herrenschmidt
There's a some duplication for what's essentially copies of two loops, so factor it. The upcoming AST2500 POST code adds more of them. Also cleanup return types for the test functions, most of them return a boolean, some return a u32. Signed-off-by: Benjamin Herrenschmidt -- v2. - Keep the split