RE: [PATCH 08/11] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-17 Thread Marek Szyprowski
Hi Laurent, On Tuesday, April 17, 2012 2:41 AM Laurent Pinchart wrote: (snipped) > > >> +static struct vm_area_struct *vb2_dc_get_user_vma( > > >> +unsigned long start, unsigned long size) > > >> +{ > > >> +struct vm_area_struct *vma; > > >> + > > >> +/* current->mm->mmap

[PATCH 08/11] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-17 Thread Laurent Pinchart
Hi Marek, On Tuesday 17 April 2012 13:25:56 Marek Szyprowski wrote: > On Tuesday, April 17, 2012 2:41 AM Laurent Pinchart wrote: > > (snipped) > > > > >> +static struct vm_area_struct *vb2_dc_get_user_vma( > > > >> + unsigned long start, unsigned long size) > > > >> +{ > > > >> + struc

[PATCH 08/11] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-17 Thread Marek Szyprowski
Hi Laurent, On Tuesday, April 17, 2012 2:41 AM Laurent Pinchart wrote: (snipped) > > >> +static struct vm_area_struct *vb2_dc_get_user_vma( > > >> +unsigned long start, unsigned long size) > > >> +{ > > >> +struct vm_area_struct *vma; > > >> + > > >> +/* current->mm->mmap

Re: [PATCH 08/11] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-17 Thread Laurent Pinchart
Hi Marek, On Tuesday 17 April 2012 13:25:56 Marek Szyprowski wrote: > On Tuesday, April 17, 2012 2:41 AM Laurent Pinchart wrote: > > (snipped) > > > > >> +static struct vm_area_struct *vb2_dc_get_user_vma( > > > >> + unsigned long start, unsigned long size) > > > >> +{ > > > >> + struc

[PATCH 08/11] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-17 Thread Laurent Pinchart
Hi Tomasz, On Wednesday 11 April 2012 12:06:59 Tomasz Stanislawski wrote: > On 04/06/2012 05:02 PM, Laurent Pinchart wrote: > > On Thursday 05 April 2012 16:00:05 Tomasz Stanislawski wrote: [snip] > > Also, Documentation/CodingStyle favors one variable declaration per line, > > without commas fo

Re: [PATCH 08/11] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-16 Thread Laurent Pinchart
Hi Tomasz, On Wednesday 11 April 2012 12:06:59 Tomasz Stanislawski wrote: > On 04/06/2012 05:02 PM, Laurent Pinchart wrote: > > On Thursday 05 April 2012 16:00:05 Tomasz Stanislawski wrote: [snip] > > Also, Documentation/CodingStyle favors one variable declaration per line, > > without commas fo

[PATCH 08/11] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-11 Thread Tomasz Stanislawski
Hi Laurent, Thank you for review. Your comments are very helpful :). Take a look on the comments below. On 04/06/2012 05:02 PM, Laurent Pinchart wrote: > Hi Tomasz, > > On Thursday 05 April 2012 16:00:05 Tomasz Stanislawski wrote: >> From: Andrzej Pietrasiewicz >> >> This patch introduces usage

Re: [PATCH 08/11] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-11 Thread Tomasz Stanislawski
Hi Laurent, Thank you for review. Your comments are very helpful :). Take a look on the comments below. On 04/06/2012 05:02 PM, Laurent Pinchart wrote: > Hi Tomasz, > > On Thursday 05 April 2012 16:00:05 Tomasz Stanislawski wrote: >> From: Andrzej Pietrasiewicz >> >> This patch introduces usage

[PATCH 08/11] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-06 Thread Laurent Pinchart
Hi Tomasz, On Thursday 05 April 2012 16:00:05 Tomasz Stanislawski wrote: > From: Andrzej Pietrasiewicz > > This patch introduces usage of dma_map_sg to map memory behind > a userspace pointer to a device as dma-contiguous mapping. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Marek

Re: [PATCH 08/11] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-06 Thread Laurent Pinchart
Hi Tomasz, On Thursday 05 April 2012 16:00:05 Tomasz Stanislawski wrote: > From: Andrzej Pietrasiewicz > > This patch introduces usage of dma_map_sg to map memory behind > a userspace pointer to a device as dma-contiguous mapping. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Marek

[PATCH 08/11] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-05 Thread Tomasz Stanislawski
From: Andrzej Pietrasiewicz This patch introduces usage of dma_map_sg to map memory behind a userspace pointer to a device as dma-contiguous mapping. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Marek Szyprowski [bugfixing] Signed-off-by: Kamil Debski [bugfixing] Signed

[PATCH 08/11] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-05 Thread Tomasz Stanislawski
From: Andrzej Pietrasiewicz This patch introduces usage of dma_map_sg to map memory behind a userspace pointer to a device as dma-contiguous mapping. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Marek Szyprowski [bugfixing] Signed-off-by: Kamil Debski [bugfixing] Signed