Re: [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev()

2021-06-16 Thread Kirti Wankhede
-static int mtty_reset(struct mdev_device *mdev) +static int mtty_reset(struct mdev_state *mdev_stte) Nit pick: s/mdev_stte/mdev_state +static const struct vfio_device_ops mtty_dev_ops = { + .name = "vfio-mdev", I think name should be different that 'vfio-mdev', probably 'vfio-m

Re: [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev()

2021-06-15 Thread Greg Kroah-Hartman
On Tue, Jun 15, 2021 at 03:35:17PM +0200, Christoph Hellwig wrote: > From: Jason Gunthorpe > > This is straightforward conversion, the mdev_state is actually serving as > the vfio_device and we can replace all the mdev_get_drvdata()'s and the > wonky dead code with a simple container_of() > > Re